Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS/OS (ProDOS 2.5.x) filename casing should be applied to the old volume name in Special > Format a Disk... and in Special > Erase a Disk... #427

Closed
c0mmander8 opened this issue Mar 7, 2021 · 3 comments
Closed

GS/OS (ProDOS 2.5.x) filename casing should be applied to the old volume name in Special > Format a Disk... and in Special > Erase a Disk... #427

c0mmander8 opened this issue Mar 7, 2021 · 3 comments
Labels
bug DeskTop DeskTop bugs or feature requests
Milestone
1.3

Comments

@c0mmander8
Copy link
Contributor

Describe the bug
GS/OS (ProDOS 2.5.x) filename casing is not applied to the old volume name in Special > Format a Disk... and in Special > Erase a Disk....

To Reproduce
Steps to reproduce the behavior:

  1. Start Apple II DeskTop with a volume with GS/OS (ProDOS 2.5.x) filename casing applied named "LIve.INstall".
  2. Click on the Special menu and go to Special > Format a Disk... or go to Special > Erase a Disk....
  3. Select the slot number and the drive number of "LIve.INstall".
  4. Enter a volume name for the new volume to be created.
  5. A dialog box appears stating "Do you want to format LIVE.INSTALL ?" or "Do you want to erase LIVE.INSTALL ?" with "LIVE.INSTALL" all in capital letters.

Expected behavior
GS/OS (ProDOS 2.5.x) filename casing should be applied to the old volume name in Special > Format a Disk... and in Special > Erase a Disk....

Screenshots
I am sorry. I have no screenshots to help explain my problem.

System Details (please complete the following information):

  • System [e.g. Apple IIe Enhanced, Apple IIc, Apple IIgs] Apple IIGS (ROM 01)
  • Emulator? [e.g. real hardware, or emulator name] GSplus 0.14 (the latest version of the program)
  • ProDOS version ProDOS 2.4.2 (the latest version)
  • DeskTop version (from About > Apple II DeskTop...) Apple II DeskTop 1.2 Alpha 27 (the latest version of the program)
  • Other [e.g. mouse, memory expansions, disk types, etc]

Additional context
There is no other context about the problem here.
@c0mmander8 c0mmander8 added DeskTop DeskTop bugs or feature requests bug labels Mar 7, 2021
@inexorabletash inexorabletash added the Won't Fix Invalid, no repro, or infeasible label Mar 8, 2021
@inexorabletash
Copy link
Collaborator

Not worth it relative to complexity.

@inexorabletash inexorabletash added Archived Unlikely to ever get attention and removed Won't Fix Invalid, no repro, or infeasible labels Dec 21, 2022
@inexorabletash
Copy link
Collaborator

Moving this from Won't Fix to Archived. Plausible using a call from the format/erase overlay's GetVol to AdjustVolumeNameCase, but complicated by the fact that the latter uses ~$800 for buffers and $1C00 for an I/O buffer, while the former has code in $800 and the actual string is in $1C00!

@inexorabletash
Copy link
Collaborator

The $1C00 conflict is no longer a problem.

inexorabletash added a commit that referenced this issue Dec 22, 2022
@inexorabletash
Desktop: Format/Erase - show volume's previous name with adjusted case
3344462 
After previous improvements, this becomes trivial.

Fixes #426. Fixes #427
@inexorabletash inexorabletash added this to the 1.3 milestone Dec 22, 2022
@inexorabletash inexorabletash removed the Archived Unlikely to ever get attention label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug DeskTop DeskTop bugs or feature requests
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@inexorabletash @c0mmander8