Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify keyboard and mouse menu navigation #754

Closed
frankmilliron opened this issue Apr 19, 2023 · 2 comments
Closed

Unify keyboard and mouse menu navigation #754

frankmilliron opened this issue Apr 19, 2023 · 2 comments
Assignees
@inexorabletash
Labels
feature request User-facing feature additions/enhancements ToolKits MouseGraphics, Icon, Button, Line Edit, List Box, etc.
Milestone
1.3

Comments

@frankmilliron
Copy link
Contributor

If "File" menu is actively being displayed, the keystroke for "Quit" is not launched when hitting OA-Q. Only clicking on the menu entry will launch the item, once the window is open. Would be nice if you could launch the item using keystrokes.
@frankmilliron frankmilliron added DeskTop DeskTop bugs or feature requests feature request User-facing feature additions/enhancements labels Apr 19, 2023
@inexorabletash inexorabletash added ToolKits MouseGraphics, Icon, Button, Line Edit, List Box, etc. and removed DeskTop DeskTop bugs or feature requests labels Apr 20, 2023
@frankmilliron
Copy link
Contributor Author

"ESC" should also close the menu if the menu entry was clicked to open. Arrow keys should traverse the menus. They do not currently. Only another mouse click will launch or close the menu.

@inexorabletash inexorabletash changed the title When menu is active, let OA-keystroke combination launch item. Unify keyboard and mouse menu navigation Apr 21, 2023
@inexorabletash
Copy link
Collaborator

After some initial exploration, it seems like it'll be necessary to do an overhaul of the keyboard menu system to integrate it better into the mouse menu system, to remove special cases and provide all of the above.

There's also a bug where certain presses get interpreted as mouse coords while the menu is showing.

inexorabletash added a commit that referenced this issue Apr 21, 2023
@inexorabletash
MGTK: Leave a comment about a bug noticed via inspection
9d6909f 
Discovered while investigating #754 - key event data can be
misinterpreted as mouse event coords, leading to strange behavior.
@inexorabletash inexorabletash self-assigned this Apr 22, 2023
@inexorabletash inexorabletash added this to the 1.3 milestone Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inexorabletash inexorabletash

Labels
feature request User-facing feature additions/enhancements ToolKits MouseGraphics, Icon, Button, Line Edit, List Box, etc.
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@inexorabletash @frankmilliron