This repository has been archived by the owner on Mar 10, 2021. It is now read-only.
Make protected calls to isDown() functions. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Love 0.11 love.keyboard.isDown() and love.mouse.isDown() raise exceptions in case of key mismatch. The current code relies on the old behaviour where no error was signaled and the function simply returned false. Protect those calls with pcall() to check if an exception is raised when the aforementioned functions are called. The change is backward compatible with older versions of Love.
|
I've modified by source code with your commit and it work perfectly, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Love 0.11 love.keyboard.isDown() and love.mouse.isDown()
raise exceptions in case of key mismatch.
The current code relies on the old behaviour where no error was signaled
and the function simply returned false.
Protect those calls with pcall() to check if an exception is raised when
the aforementioned functions are called.
The change is backward compatible with older versions of Love.