added ut

a49a · Feb 15, 2023 · 425c536 · 425c536
1 parent d4dc21a
commit 425c536
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java b/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java
@@ -177,7 +177,7 @@ int initArgs(String[] args) {
     }
     if (!commands.isEmpty()) {
       for (Iterator<String> i = commands.iterator(); i.hasNext(); ) {
-        String command = HiveStringUtils.removeComments(i.next().toString());
+        String command = i.next().toString();
         debug(loc("executing-command", command));
         if (!dispatch(command)) {
           code++;
@@ -193,4 +193,9 @@ int initArgs(String[] args) {
     }
     return code;
   }
+
+  @Override
+  boolean dispatch(String line) {
+    return super.dispatch(HiveStringUtils.removeComments(line));
+  }
 }
diff --git a/kyuubi-hive-beeline/src/test/java/org/apache/hive/beeline/KyuubiBeeLineTest.java b/kyuubi-hive-beeline/src/test/java/org/apache/hive/beeline/KyuubiBeeLineTest.java
@@ -29,4 +29,13 @@ public void testKyuubiBeelineWithoutArgs() {
     int result = kyuubiBeeLine.initArgs(new String[0]);
     assertEquals(0, result);
   }
+
+  @Test
+  public void testKyuubiBeelineComment() {
+    KyuubiBeeLine kyuubiBeeLine = new KyuubiBeeLine();
+    int result = kyuubiBeeLine.initArgsFromCliVars(new String[] { "-e", "--comment show database;" });
+    assertEquals(0, result);
+    result = kyuubiBeeLine.initArgsFromCliVars(new String[] {"-e", "--comment\n show database;" });
+    assertEquals(1, result);
+  }
 }