Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extra vars for deployment #45

Open
abennani82 opened this issue Sep 6, 2024 · 2 comments · May be fixed by #47
Open

Use extra vars for deployment #45

abennani82 opened this issue Sep 6, 2024 · 2 comments · May be fixed by #47

Comments

@abennani82
Copy link

abennani82 commented Sep 6, 2024

Hi,
I had to enable emails on n8n and to do that i have to deploy new env. It is not possible with the actual chart version to add new env vars others then those expected.

It is possible de add possibility to have extraVars sections in values.
extraVars:
var1: value1
var2: value2
in n8n config map add at the end after other envs :
{{- range $key, $value := .Values.extraEnv }}

  • name: {{ $key }}
    value: {{ $value | quote}}
    {{ end }}
    or

{{ if Values.extraEnv }}
{{ .Values.extraEnv | toYaml | trim | nindent 2 }}
{{ end }}
Regards

@a5r0n
Copy link
Owner

a5r0n commented Sep 6, 2024

Great point @abennani82 👍
Env vars are coming from the config map, so this is the right place to add this,
PR are welcome!

@abennani82
Copy link
Author

PR ready for review.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants