feat(configmap): Add possibility to provide extra vars in configmap. #47
+10
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can i add the ability to provide external secret ( for N8N_ENCRYPTION_KEY for example) to this PR or it has to be in a separate one? |
a5r0n
requested changes
Sep 6, 2024
| DB_LOGGING_OPTIONS: {{ .Values.n8n.db_logging_options | default "all" | quote }} | ||
| {{- with .Values.extraEnvs }} |
There was a problem hiding this comment.
i'd like to keep things orgainzied, all n8n relatead config should be inside .Values.n8n block
Suggested change
| {{- with .Values.extraEnvs }} | |
| {{- with .Values.n8n.extraEnvs }} |
separate one please 🙏🏻 |
|
Ok.
I’m waiting the validation of the first PR to send u the second one.
Aissam BENNANI
Le ven. 6 sept. 2024 à 16:31, a5r0n ***@***.***> a écrit :
… Can i add the ability to provide external secret ( for N8N_ENCRYPTION_KEY
for example) to this PR or it has to be in a separate one?
separate one please 🙏🏻
—
Reply to this email directly, view it on GitHub
<#47 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKCQC5XBHUDMSD5BKO54WVLZVG4F5AVCNFSM6AAAAABNYVCYMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGE4TEMRVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
a5r0n
reviewed
Sep 9, 2024
|
I thaught it was already there.
I fix that
Aissam BENNANI
Le lun. 9 sept. 2024 à 21:47, a5r0n ***@***.***> a écrit :
… ***@***.**** commented on this pull request.
Can you remove the Chart.{yaml/lock} and dependent charts from this PR?
—
Reply to this email directly, view it on GitHub
<#47 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKCQC5SCOBZIHR3MYAGUAWDZVX3NFAVCNFSM6AAAAABNYVCYMSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJQHAYTCNJXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Resources deleted |
|
Hi |
|
@abennani82 you also deleted the charts them self, not just from the git commit.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
PR de fix #45 as requested.
Thanks for review
Regards