Simplify linking of custom Arduino libraries #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a custom arduino library is added using add_custom_arduino_library or add_custom_arduino_core, then all the targets, within the directory tree, link with that custom arduino library. Earlier mechanism, which is still supported, required explicit linking and was inflexible and confusing especially when some arduino libraries are linked automatically. Example: add_custom_arduino_core(my_core) # If the following linking happens within the current cmake # directory tree, then my_target links with my_core, instead of # the inbuilt core. target_link_arduino_libraries(my_target core) In future, an explicit scoping mechanism for the custom libraries may be provided (SCOPE_LOCAL, SCOPE_GLOBAL, SCOPE_TREE). The default scope is SCOPE_TREE (which is the current behaviour in this patch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom arduino library is added using add_custom_arduino_library
or add_custom_arduino_core, then all the targets, within the directory
tree, link with that custom arduino library. Earlier mechanism, which
is still supported, required explicit linking and was inflexible and
confusing especially when some arduino libraries are linked
automatically.
Example:
add_custom_arduino_core(my_core)
# If the following linking happens within the current cmake
# directory tree, then my_target links with my_core, instead of
# the inbuilt core.
target_link_arduino_libraries(my_target core)
In future, an explicit scoping mechanism for the custom libraries may
be provided (SCOPE_LOCAL, SCOPE_GLOBAL, SCOPE_TREE). The default scope
is SCOPE_TREE (which is the current behaviour in this patch).