Update ls.video-embed.js #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make thumb-size defined through html attribute.
aFarkas
added a commit
that referenced
this pull request
Aug 4, 2019
|
Sorry that I haven't answered you. I implemented your request but did it a little bit differently. I hope you are ok with it. Good idea!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alexander. Do you think this might be useful to be able to control the thumbnail size? I ran into this issue a couple of times with the thumb size of standard hqdefault quality being too low. This way one can easily switch from hqdefault or maxresdefault.