Import fix #1
Merged
Import fix #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2017 16:06
* Out of the box I was unable to run the quickstart.py example, because the setup.py did not require __pandas-datareader__ or __seaborn__.
* It looks like there was a change to the the generator interface that was intended, but not implemented. When I attempted to run tox I encountered the error: E TypeError: __init__() got an unexpected keyword argument 'cache_path' This was because the attempt to create an instance of the YahooData generator was passing cache_path, which was not in the parameter list for the class. I've added both cache_path and data_path as well as `__init__` methods for all generators so that they invoke the base class `__init__` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dependency issue in setup.py and fixes tests.