Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Fix performance testing #167

Closed
VanishMax opened this issue Mar 30, 2022 · 4 comments · Fixed by #200
Closed

Fix performance testing #167

VanishMax opened this issue Mar 30, 2022 · 4 comments · Fixed by #200
Assignees
Milestone

Comments

@VanishMax
Copy link
Collaborator

VanishMax commented Mar 30, 2022

For now, performance testing uses present: 'lighthouse:recommended', which sets the recommended configurations to the lighthouserc.json. Our application cannot handle them for now, thus the CI fails.

The task is to fix these issues or configure the assess field, so the CI will pass successfully.

Acceptance criteria:

  • CI passes
  • Problematic points are fixed or the threshold for them is changed in the assess field of the Lighthouse config. Also, it would be nice to write a description in this PR of why the threshold has been changed.
@illright illright added this to the Sprint 9 milestone Apr 4, 2022
@illright illright self-assigned this Apr 4, 2022
@VanishMax
Copy link
Collaborator Author

One more thing to do here is to check the checkbox in our Readme about Lighthouse tests

@illright
Copy link
Collaborator

illright commented Apr 5, 2022

That's done already

@VanishMax
Copy link
Collaborator Author

Wait, is it different for us?

image

@illright
Copy link
Collaborator

illright commented Apr 5, 2022

Oh, sorry, forgot that it is still not merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants