This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix Lighthouse errors #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the 'self' source and removed 'https' and 'strict-dynamic' 'https' would allow scripts from any HTTPS source and 'strict-dynamic' doesn't work with SvelteKit yet
illright
suggested changes
Apr 14, 2022
src/app.html
Outdated
| @@ -4,6 +4,7 @@ | |||
| <meta charset="utf-8" /> | |||
| <meta name="description" content="Listen to podcasts on the web, wherever!" /> | |||
| <link rel="manifest" href="%svelte.assets%/manifest.json" /> | |||
| <link rel="preconnect" href="https://sklgqhbbbhticzdgegcj.supabase.co" /> | |||
There was a problem hiding this comment.
issue: I don't think we should hard-code this
suggestion: in the app layer, there are a few components that manage meta tags, perhaps you could move it there and use the value from the environment variable?
To use the environment variable
Deploying with
|
| Latest commit: |
0591154
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d49ed48d.cast-iu.pages.dev |
illright
approved these changes
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 71.54% 71.54%
=======================================
Files 66 66
Lines 629 629
Branches 162 162
=======================================
Hits 450 450
Misses 167 167
Partials 12 12 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enabled the CSP again but disabled the
strict-dymanicsource since SvelteKit doesn't support it properly yet (sveltejs/kit#3558).As for the
unused-javascriptissue, I disabled the assertion since it is mostly not in our control (and SvelteKit basically closed the issue aswontfix- sveltejs/kit#1371). It might be possible to work around it (according to this Reddit comment), but it feels like a dirty hack, so I'd say it's good as it is now.Resolves #167