Docs: Fix code highlighting in third-party libraries integration guide #268
Conversation
This prevents problems with pip-compile on systems where Python 3.12 is the default system interpreter.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 5 5
Lines 388 388
Branches 72 72
=======================================
Hits 366 366
Misses 13 13
Partials 9 9 ☔ View full report in Codecov by Sentry. |
| additional_dependencies: ["bandit[toml]"] | ||
| - id: bandit | ||
| args: [-c, pyproject.toml] | ||
| additional_dependencies: ["bandit[toml]"] |
There was a problem hiding this comment.
I agree with these indents here (and above). But Nicho noted them on another PR from me. Do we have a projet standard on these idents/formatting things?
There was a problem hiding this comment.
The rest of the file uses this style of indentation. From a quick look we also use it in the other files.
AFAIK, we do not have a standard defined.
There was a problem hiding this comment.
We don't, but at least each file should be consistent. FWIW, I consider whatever defaults the YAML plugin in VS Code has my standard (which is why the file got reformatted when I saved it).
After a refactoring of the transactions feature, the code examples themselves were modied, but not the page that highlights some lines in them.
This PR updates those code blocks to make them consistent with the actual example code.
Additionally, it pins the Python version used for pre-commit hooks to 3.11, to prevent problems on systems with Python 3.12 (which would be used to lock dependencies using
pip-compile, which includes the Python version number in a comment in the generated dependency lock file).Closes #267