Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools_scm in favor of explicit version management #156

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

nicholasjng
Copy link
Collaborator

setuptools_scm has a few drawbacks to version management by hand, such as inflexibility for releasing off-tag, and missing info on shallow checkouts.

As such, revert back to a static version number, with tagged commits as version bumps.

setuptools_scm has a few drawbacks to version management by hand, such
as inflexibility for releasing off-tag, and missing info on shallow
checkouts.

As such, revert back to a static version number, with tagged commits as
version bumps.
@nicholasjng
Copy link
Collaborator Author

To get a dev version of nnbench to appear in the lockfile, we could tag a development version with a dev suffix (maybe not numbered). Then we can access the actual revision as git rev-parse HEAD.

@nicholasjng nicholasjng merged commit 3b27774 into main Oct 30, 2024
14 checks passed
@nicholasjng nicholasjng deleted the remove-scm branch October 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant