Change nnbench.reporter file to submodule, add base reporter
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Questions (among others):
|
nicholasjng
force-pushed
the
extend-reporter-interface
branch
from
4a014ec to
4a1a8ba
Compare
The interface has been scratched in a GitHub issue previously, this is its (tentative) implementation. It's not yet to be considered stable, and we will likely defer v0.2.0 until at least either a file or database reporter has been implemented. Since the added benchmark record merge has raised the question of how we want to treat heterogeneous contexts, we should consider adding a proper Context object in a follow-up. This is mostly a restructuring, so no new tests.
nicholasjng
force-pushed
the
extend-reporter-interface
branch
from
4a1a8ba to
703ac37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface has been scratched in a GitHub issue previously, this is its (tentative) implementation.
It's not yet to be considered stable, and we will likely defer v0.2.0 until at least either a file or database reporter has been implemented.
Since the added benchmark record merge has raised the question of how we want to treat heterogeneous contexts, we should consider adding a proper Context object in a follow-up.
This is mostly a restructuring, so no new tests.