Unify batching in file drivers, remove read/write stubs on base reporter #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the reporter interface is so dynamic (i.e., file I/O needs vastly different arguments than DB I/O), we scrap the read/write APIs from the base class and add it as needed in the child classes. Adds batched (i.e., multi-record) read/write support and a `FileReporter` class that is just the sum of the `FileIO` and `BenchmarkReporter` interfaces.
nicholasjng
force-pushed
the
reporter-refactor
branch
from
60cd0c4 to
36aa427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the reporter interface is so dynamic (i.e., file I/O needs vastly different arguments than DB I/O), we scrap the read/write APIs from the base class and add it as needed in the child classes.
Adds batched (i.e., multi-record) read/write support and a
FileReporterclass that is just the sum of theFileIOandBenchmarkReporterinterfaces.