fix: handle missing 'number_plate' key in check_bills_all_vehicles function #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakvatech
requested changes
Jun 4, 2024
nelsonmpanju
changed the title
miteshpc
approved these changes
Jun 19, 2024
| except Exception as e: | ||
| frappe.log_error(frappe.get_traceback(), str(e)) | ||
| number_plate = vehicle.get("number_plate") or vehicle.get("license_plate") | ||
| vehicle_name = vehicle.get("name") |
There was a problem hiding this comment.
You don't need a get for "name". It will ALWAYS be there
| def get_bills(number_plate): | ||
| headers = { | ||
| 'x-transfer-key': 'e9f3e572-db87-4eff-9ed6-66922f1f7f24', | ||
| } | ||
|
|
||
| url = ( | ||
| "https://termis.tarura.go.tz:6003/termis-parking-service/api/v1/parkingDetails/debts/plateNumber/" | ||
| "http://termis.tarura.go.tz:6003/termis-parking-service/api/v1/parkingDetails/debts/plateNumber/" |
miteshpc
approved these changes
Jun 19, 2024
aakvatech
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e' key