feat: add missing usage fields #435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue aallam#434
aallam
requested changes
Apr 23, 2025
| /** | ||
| * Cached tokens present in the prompt. | ||
| */ | ||
| public val cachedTokens: Int? = null, |
There was a problem hiding this comment.
Could you please add @SerialName for all fields? thanks!
| JsonPrimitive("response") | ||
| )) | ||
| )) | ||
| val schemaJson = JsonObject( |
There was a problem hiding this comment.
To test serialization, add a new test function that uses a sample JSON response and verifies that serialization works correctly; here is an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #434
Note: Could not figure out how to run the tests. Please provide guidance @aallam
Describe your change
Add the missing fields to Usage.kt
What problem is this fixing?
See #434