Project import generated by Copybara. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen-aalyria
force-pushed
the
FFDC92B3A447757D4EF1575AD3E882CA
branch
2 times, most recently
from
76e8913 to
d05c069
Compare
|
Just curious, what branch was the Copybara script run from? (Most customer instances are on stable, so running from the branch on that release channel is typically the safest.) |
|
This is from a "fix the API BUILD file" branch, where there are some minor changes, but it's based on main. Happy to rebase onto the current stable branch. |
GitOrigin-RevId: 4ad38248a862d81ac023fe981778ae2512212fad
helen-aalyria
force-pushed
the
FFDC92B3A447757D4EF1575AD3E882CA
branch
from
d05c069 to
523560c
Compare
|
I should have mentioned that I did rebase to 8.68 at the time of that comment! |
|
LGTM! Just as a heads up, stable is currently on release-8.67. |
nihar-aalyria
approved these changes
Apr 30, 2024
|
Ah sorry that's what I meant! There wasn't even a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project import generated by Copybara.