Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project import generated by Copybara. #86

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Project import generated by Copybara. #86

merged 1 commit into from
Jul 10, 2024

Conversation

ciarand
Copy link
Member

@ciarand ciarand commented Jul 10, 2024

GitOrigin-RevId: 30a2f95d5b9e12f4c954f1ecc02b0c720314ab95

@ciarand
Project import generated by Copybara.
83fe5ab 
GitOrigin-RevId: 30a2f95d5b9e12f4c954f1ecc02b0c720314ab95
@ciarand ciarand requested review from ek345 and nihar-aalyria July 10, 2024 01:04
@dgnemo dgnemo self-requested a review July 10, 2024 01:13
ek345
ek345 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@ek345 ek345 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the possible exception of the BeamConfig Endpoint stuff, which I thought we rolled back because it's not being used in the candidate environment...

@dgnemo dgnemo merged commit 7a8d580 into main Jul 10, 2024
20 checks passed
@dgnemo dgnemo deleted the F153A843948F8E4CE45BFDC669542A50 branch July 15, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ek345 ek345 ek345 approved these changes

@nihar-aalyria nihar-aalyria nihar-aalyria approved these changes

@dgnemo dgnemo dgnemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarand @dgnemo @ek345 @nihar-aalyria