-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: do not call captureException/captureMessage in a setImmediate #34
Conversation
Somehow, doing so, will lose scope.setTag and scope.setExtra results Instead, wrap whole setScope inside a function
Perhaps should just not combine Sentry.withScope and setImmediate, but I moved everything, so it's simpler to understand. |
@aandrewww please merge #34 or #32 I prefer #34 because it's a more compact change. and release as 0.9.1 bugfix |
@glensc hi. |
@glensc and @aandrewww, the only issue I foresee with this PR is that it does not set the proper log level. Where as with #32 it properly sets the log level. |
@jdkajewski you just guess, or do you have a reproducer? |
@glensc The issue shows up with different log levels for exceptions. We're not seeing it capture the difference between fatal and error exceptions unless you call |
I will review and test this PR tomorrow |
perhaps go with #32 then, or need to add scope.setLevel to this branch? none of them matter much if v7 comes as there's a new API for transports |
superseded by #32 |
Somehow, doing so, will lose scope.setTag and scope.setExtra results
Instead, wrap whole setScope inside a function.