Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added syntax highlight #67

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Added syntax highlight #67

merged 1 commit into from
Oct 19, 2018

Conversation

yisonPylkita
Copy link
Contributor

@yisonPylkita yisonPylkita commented Oct 18, 2018

Hi @aantron

Thank you for this library. Was a great help in my projects.

I noticed that README does not have a syntax highlight so I created this PR

@aantron
Copy link
Owner

aantron commented Oct 18, 2018

Great, thanks!

One request: could you restore the indentation inside the Markdown file? With the original indentation, the code blocks were part of the list items that they were "trying" to be in. With the indentation removed, they are treated as outside the list items. In the case of item (1), this also has the side-effect of taking the paragraph following the code block out of the list item. Preview.

@yisonPylkita
Copy link
Contributor Author

Thanks for review :)

Fixed indentations. Should be fine now

@aantron aantron merged commit 94f8f95 into aantron:master Oct 19, 2018
@aantron
Copy link
Owner

aantron commented Oct 19, 2018

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants