fix -wold-style-cast
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #48 |
aantron
reviewed
Jun 14, 2019
enum.h
Outdated
| # endif | ||
| #endif | ||
| // msvc does not recognize `_Pragma` | ||
| #ifdef _MSC_VER |
There was a problem hiding this comment.
I think this should be #else, since we need the macros defined (expanding to nothing, as below) for all other compilers, not just MSVC.
There was a problem hiding this comment.
I believe you updated the wrong #ifdef, one of the ones below here.
There was a problem hiding this comment.
woops, it should be fixed now
aantron
reviewed
Jun 18, 2019
enum.h
Outdated
| @@ -37,7 +61,7 @@ | |||
| # endif | |||
| #endif | |||
|
|
|||
| #ifdef _MSC_VER | |||
| #ifdef _MSVC_VER | |||
There was a problem hiding this comment.
Should be _MSC_VER, not _MSVC_VER, i.e. there should be no diff on this line.
There was a problem hiding this comment.
crap!
just fixed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #71