Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bigstringaf instead of Lwt_bytes to remove unix dependencies #107

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

dinosaure
Copy link
Contributor

Lwt_bytes comes with some syscalls such as read/write on Unix file-descriptor. This PR is a simple replacement of Lwt_bytes by bigstringaf which is compatible with MirageOS.

@aantron
Copy link
Owner

aantron commented Jul 5, 2021

The PR looks fine.

The CI is showing this warning (as error):

File "src/pure/body.ml", line 139, characters 8-24:
139 |         Bigstringaf.blit !buffer 0 new_buffer 0 !length;
              ^^^^^^^^^^^^^^^^
Error (warning 6): labels src_off, dst_off, len were omitted in the application of this function.

and a few more like it. Could you address these? I will then merge.

@dinosaure
Copy link
Contributor Author

Yes will do a patch tonight 👍

@dinosaure
Copy link
Contributor Author

Done ✔️

@aantron aantron merged commit dd2b8dc into aantron:master Jul 5, 2021
@aantron
Copy link
Owner

aantron commented Jul 5, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants