Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Style Improvement #124

Merged
merged 5 commits into from Jul 10, 2021
Merged

Playground Style Improvement #124

merged 5 commits into from Jul 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2021

Dear, Maintainer.

I do this PR because #105 about making playground look nicer.
The thing i done :

  • Adding horizontal scroll in Logging section.
  • Add change view button for switch Editor and Client expand.

This how it look like :
log_scroll

change_view_button

@aantron
Copy link
Owner

aantron commented Jul 10, 2021

With this version, when I first go to http://dream.as/, the bottom line of the log is clipped:

Снимок

and the horizontal scroll bar is drawn beneath the viewport:

clipped

so that there is a vertical scroll bar on the right side of the whole window (see right edge in the above screenshot), and you have to scroll down to see the log's horizontal scroll bar and the rest of the first line.

Also, the new button does not seem to do anything on my browser (Brave).

The version from this PR is deployed right now, so you can take a look.

You should be able to save the HTML as a local file, and maybe even the JS, to help develop this.

@thangngoc89
Copy link
Contributor

vertical scroll bar on the right side of the whole window

This is because the whole layout is starting the break when we add new features. Ideally, everything should be calculated using flex: 100vh for body and everything inside it scale accordingly.

Also, the new button does not seem to do anything on my browser (Brave).

There is error in console. Uncaught TypeError: Cannot set property 'onclick' of null

@thangngoc89
Copy link
Contributor

I would say merge this PR and redo the vertical layout in another PR. Manually calculating height in px is very fragile :) cc @aantron

@aantron aantron merged commit 027f7b4 into aantron:master Jul 10, 2021
@aantron
Copy link
Owner

aantron commented Jul 10, 2021

I would say merge this PR and redo the vertical layout in another PR. Manually calculating height in px is very fragile :) cc @aantron

Very well.

Thanks @artileda for the main work and @thangngoc89 for the review!

I've pushed the latest version as of this PR to dream.as. Happy to see that the button works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants