Prevent Codemirror to grow #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there're too many lines, the editor would grow to fit the whole content. The usual fix would be defining a maximum height on parent container of `.CodeMirror` and `position: relative`. Since parent container is this case (`#textarea`) grow with its container (`#editor`), maximum height can't be set without resorting to manual `calc` . This PR implement a hacks documented here: https://discuss.codemirror.net/t/size-inside-flexbox/1359/5 You can test this by making the editor has more lines than its parent container. For example: http://dream.as/k-websocket
|
Deployed and confirmed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there're too many lines, the editor would grow to fit the whole content.
The usual fix would be defining a maximum height on parent container of
.CodeMirrorand
position: relative.Since parent container is this case (
#textarea) grow with its container (#editor),maximum height can't be set without resorting to manual
calc.This PR implement a hacks documented here: https://discuss.codemirror.net/t/size-inside-flexbox/1359/5
You can test this by making the editor has more lines than its parent container.
For example: http://dream.as/k-websocket