Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: add w-mlx #330

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Examples: add w-mlx #330

merged 1 commit into from
Oct 14, 2024

Conversation

andreypopp
Copy link
Contributor

@andreypopp andreypopp commented Jul 10, 2024

Adds an example using mlx.

mlx is an OCaml dialect which extends regular OCaml syntax with JSX expressions. The dialect features first class support from merlin/lsp.

@aantron
Copy link
Owner

aantron commented Aug 8, 2024

Thanks! This looks great! I'm playing around with it.

What is needed to get the syntax highlighting to work? I have this example building and running with the exact code in this PR. I am using:

VSCode 1.92.1
OCaml Platform 1.20.0
OCaml 5.2.0
Dune 3.16.0
ocaml-lsp-server 1.18.0~5.2preview
ocamlmerlin-mlx 0.9
mlx 0.9

@andreypopp
Copy link
Contributor Author

andreypopp commented Aug 9, 2024

What is needed to get the syntax highlighting to work? I have this example building and running with the exact code in this PR. I am using:

Unfortunately this needs an extension for vscode which doesn't yet exist.

Though there exists a tree-sitter-mlx parser I use in the ocaml_mlx.nvim so if there's some generic vscode extensions which could use tree sitter parsers for highlighting then it'd work now.

@aantron aantron merged commit 6a1a2f0 into aantron:master Oct 14, 2024
2 of 13 checks passed
@aantron
Copy link
Owner

aantron commented Oct 14, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants