Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused documentation #342

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

maxRN
Copy link
Contributor

@maxRN maxRN commented Sep 3, 2024

This PR removes two parts of unused / superseded documentation upload_event and new_global.
upload_event was changed in commit 018e8e273c5e01e24efefa8e2b2b5a9e4145c7a1.
new_global was replaced by new_field I think, in commit 2cb98ad0a6e64d30144a2c6aef65140e6d5589fd.

@maxRN
Copy link
Contributor Author

maxRN commented Sep 3, 2024

One more thing I forgot to mention: I only stumbled on these unused functions, because I somehow triggered a dune build that displayed those as errors. However I can't figure out how to get dune to display those errors again 😅 (I'm also surprised that it would even build in the first place while having unused functions)

@aantron aantron merged commit 2b13c32 into aantron:master Sep 3, 2024
0 of 13 checks passed
@aantron
Copy link
Owner

aantron commented Sep 3, 2024

Thank you! new_global was removed in d81b198. new_field replaces new_local (a rename), while "globals" were associated with "apps," a concept which was completely deleted in d81b198. Thanks for being thorough with the history search -- it saves me time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants