Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reference on e-json example for Dream.json #359

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Added reference on e-json example for Dream.json #359

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26e082d
Added reference on e-json example for Dream.json
alxtuz Oct 30, 2024
5899950
Changed link to #files anchor
alxtuz Oct 30, 2024
f264fb2
Fixed link's anchor and text
alxtuz Nov 1, 2024
a2f3986
Reverted security anchor
alxtuz Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/dream.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,11 @@ val json :
?headers:(string * string) list ->
string -> response promise
(** Same as {!Dream.respond}, but adds [Content-Type: application/json]. See
{!Dream.application_json}. *)
{!Dream.application_json}.

See example
{{:https://github.com/aantron/dream/tree/master/example/e-json#e-json}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link to a permanent anchor like #files, as most of the other example links do? The anchor #e-json will become invalid if the example ever gets renamed, or even if we just adopt a different style of titling the examples without renaming or renmbering them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
For unknown reason test on windows failed. Seems it's sporadic event that wasn't caused by these changes.

[e-json]}. *)

val redirect :
?status:[< redirection ] ->
Expand Down