-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add support for flash messages. #62
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3b3b130
Add a crude first version of flash messages.
jsthomas 34cd57d
Get more organized.
jsthomas 73887c3
Build a simple example to illustrate usage.
jsthomas d75cd43
Merge branch 'master' of github.com:jsthomas/dream into flash-messages
jsthomas 9c58ee5
Correct esy file.
jsthomas a95e91a
Revisions from review.
jsthomas f6e9822
Revise to use a bare-cookie approach, revert sessions to master.
jsthomas 99552c5
Further simplifications based on feedback.
jsthomas 1e664be
Refactor to support multiple messages of the same category.
jsthomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
(executable | ||
(name flash_message) | ||
(libraries dream tyxml) | ||
(preprocess (pps lwt_ppx))) | ||
|
||
(rule | ||
(targets flash_message.ml) | ||
(deps flash_message.eml.ml) | ||
(action (run dream_eml %{deps} --workspace %{workspace_root}))) | ||
|
||
(data_only_dirs _esy esy.lock) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
(lang dune 2.0) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"dependencies": { | ||
"@opam/dream": "1.0.0~alpha2", | ||
"@opam/dune": "^2.0", | ||
"ocaml": "4.12.x" | ||
}, | ||
"resolutions": { | ||
"@opam/conf-libev": "esy-packages/libev:package.json#0b5eb6685b688649045aceac55dc559f6f21b829" | ||
}, | ||
"scripts": { | ||
"start": "dune exec --root . ./flash_message.exe" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
let input_form request = | ||
<html> | ||
<body> | ||
Enter some text: | ||
<%s! Dream.form_tag ~action:"/" request %> | ||
<input name="text" autofocus> | ||
</form> | ||
</body> | ||
</html> | ||
|
||
|
||
let results_page messages text = | ||
let open Tyxml.Html in | ||
let to_p (category, msg) = p [txt (category ^ " : " ^ msg)] in | ||
html ( head (title (txt "Flash Messages Demo")) [] ) | ||
( body @@ | ||
List.map to_p messages @ | ||
[p [txt @@ Option.value text ~default:""]] | ||
) | ||
|
||
|
||
let html_to_string html = | ||
Format.asprintf "%a" (Tyxml.Html.pp ()) html | ||
|
||
|
||
let () = | ||
Dream.run | ||
@@ Dream.logger | ||
@@ Dream.memory_sessions | ||
@@ Dream.flash_messages | ||
@@ Dream.router [ | ||
Dream.get "/" | ||
(fun request -> | ||
Dream.html (input_form request)); | ||
|
||
Dream.post "/" | ||
(fun request -> | ||
match%lwt Dream.form request with | ||
| `Ok ["text", text] -> | ||
let () = Dream.put_flash "Info" "Message 1" request in | ||
let () = Dream.put_flash "Info" "Message 2" request in | ||
let () = Dream.put_flash "Debug" "Message 3" request in | ||
let%lwt () = Dream.put_session "text" text request in | ||
Dream.redirect request "/results" | ||
| _ -> | ||
Dream.redirect request "/" | ||
); | ||
|
||
Dream.get "/results" | ||
(fun request -> | ||
let messages = Dream.get_flash request in | ||
let text = Dream.session "text" request in | ||
Dream.html @@ html_to_string @@ results_page messages text); | ||
] | ||
@@ Dream.not_found |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
module Dream = Dream__pure.Inmost | ||
|
||
|
||
let log = | ||
Log.sub_log "dream.flash_message" | ||
|
||
|
||
let five_minutes = 5. *. 60. | ||
|
||
|
||
let storage = Dream.new_local ~name:"dream.flash_message" () | ||
|
||
|
||
let flash_cookie = "dream.flash_message" | ||
|
||
|
||
let flash_messages inner_handler request = | ||
let outbox = ref [] in | ||
let request = Dream.with_local storage outbox request in | ||
let%lwt response = inner_handler request in | ||
Lwt.return( | ||
let entries = List.rev !outbox in | ||
let content = List.fold_right (fun (x,y) a -> `String x :: `String y :: a) entries [] in | ||
let value = `List content |> Yojson.Basic.to_string in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if using Yojson to serialize is the right approach. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is a right approach. |
||
Dream.set_cookie flash_cookie value request response ~max_age:five_minutes | ||
) | ||
|
||
|
||
let (|>?) = | ||
Option.bind | ||
|
||
|
||
let get_flash request = | ||
let rec group x = match x with | ||
| x1::x2::rest -> (x1, x2) :: group rest | ||
| _ -> [] | ||
in | ||
let unpack u = match u with | ||
| `String x -> x | ||
| _ -> failwith "Bad flash message content" in | ||
let x = Dream.cookie flash_cookie request | ||
|>? fun value -> | ||
match Yojson.Basic.from_string value with | ||
| `List y -> Some (group @@ List.map unpack y) | ||
| _ -> None | ||
in Option.value x ~default:[] | ||
|
||
|
||
let put_flash category message request = | ||
let outbox = match Dream.local storage request with | ||
| Some outbox -> outbox | ||
| None -> | ||
let message = "Missing flash message middleware" in | ||
log.error (fun log -> log ~request "%s" message); | ||
failwith message in | ||
outbox := (category, message) :: !outbox |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is mixing Tyxml (in
results_page
) and templates (ininput_form
) like this idiomatic? I couldn't figure out how to implementresults_page
using templates.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll edit this example to not use TyXML after the merge, and ping.