Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Belt everywhere. #58

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Use Belt everywhere. #58

merged 1 commit into from
Jun 20, 2020

Conversation

cknitt
Copy link
Contributor

@cknitt cknitt commented Jun 20, 2020

As discussed in #57, make sure that on the JS side we import only belt_Array.js and not caml_array.js, too.

@aantron aantron merged commit 0fb6c93 into aantron:master Jun 20, 2020
@aantron
Copy link
Owner

aantron commented Jun 20, 2020

Thanks! This decreased the incremental (that is, compared to someone already using Belt) compiled size from 3913 bytes to 1184 bytes.

@aantron
Copy link
Owner

aantron commented Jun 20, 2020

Travis CI status reporting seems to be broken for PRs at the moment. There are several bug reports like this one at Travis with no satisfactory solution yet. The builds are running, though, e.g. https://travis-ci.org/github/aantron/promise/builds/700295405 ran for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants