Change how the validation label is constructed #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaomidi
force-pushed
the
dnsops
branch
6 times, most recently
from
c31260f
to
2916810
Compare
daknob
requested changes
Sep 7, 2023
There was a problem hiding this comment.
In addition to these suggestions, the Security Considerations are no longer true:
As this challenge that is introduced only differs in the left-most label of the domain name from the existing dns-01 challenge, the same security considerations apply.
If we move forward with this, we'd need to redo our security assessment and impact analysis, and see if anything noteworthy comes up.
|
Seems okay so far, pending the changes from the dnsop draft. We'd like to cite that somewhere. |
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13
Trying to get closer to the generic dns validations method document: https://datatracker.ietf.org/doc/draft-ietf-dnsop-domain-verification-techniques/