feat!: support CRLs with multiple issuers #26
+145
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: aarnaud#19 It is common practice to have multiple issuers and therefore CRLs in a single Vault PKI secrets engine. Previously we'd only have metrics for the default issuer in a PKI secrets engine. This refactors metrics gathering to support CRL related metrics for all issuers in a secrets engine. This is marked as a breaking change due to the *addition* of an `issuer` label to metrics like `x509_crl_length` but in most cases adding a new label to existing metrics won't break alerting or recording rules compared to removing a label. Regardless proper notice is given. Old metric example: ``` x509_crl_nextupdate{source="pki/"} 1.730633058e+09 ``` New metric example: ``` x509_crl_nextupdate{issuer="CN=my-website.com",source="pki/"} 1.730633058e+09 x509_crl_nextupdate{issuer="CN=mysecondwebsite.com",source="pki/"} 1.730633058e+09 ```
pkix.CertificateList is deprecated, switches to x509.RevocationList instead. Minimal methods need to change
Resolves: aarnaud#19 It is common practice to have multiple issuers and therefore CRLs in a single Vault PKI secrets engine. Previously we'd only have metrics for the default issuer in a PKI secrets engine. This refactors metrics gathering to support CRL related metrics for all issuers in a secrets engine. This is marked as a breaking change due to the *addition* of an `issuer` label to metrics like `x509_crl_length` but in most cases adding a new label to existing metrics won't break alerting or recording rules compared to removing a label. Regardless proper notice is given. Old metric example: ``` x509_crl_nextupdate{source="pki/"} 1.730633058e+09 ``` New metric example: ``` x509_crl_nextupdate{issuer="CN=my-website.com",source="pki/"} 1.730633058e+09 x509_crl_nextupdate{issuer="CN=mysecondwebsite.com",source="pki/"} 1.730633058e+09 ```
pkix.CertificateList is deprecated, switches to x509.RevocationList instead. Minimal methods need to change
…ef/multiple_issuer_crls
prettier to just use CN
|
Thanks for this PR, I will try to review it quickly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #19
It is common practice to have multiple issuers and therefore CRLs in a
single Vault PKI secrets engine. Previously we'd only have metrics for
the default issuer in a PKI secrets engine. This refactors metrics
gathering to support CRL related metrics for all issuers in a secrets
engine.
This is marked as a breaking change due to the addition of an
issuerlabel to metrics like
x509_crl_lengthbut in most cases adding a newlabel to existing metrics won't break alerting or recording rules
compared to removing a label. Regardless proper notice is given.
Old metric example:
New metric example:
Also adds contributing instructions and upgrades us from deprecated
pkix.CertificateListtox509.RevocationList