Implements what is hopefully a safer time limit check #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarondandy
force-pushed
the
utc-ticks
branch
from
4463459 to
a09ab0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know the root cause of the issue mentioned in #78 but I have a hunch this might be related. I'm hopeful that moving away from
Environment.TickCountwill at least make the code a bit more resilient. This change comes with some reduced performance when checking incorrect words, but I think it is worth the cost. Based on what I have read,Environment.TickCountisn't very reliable, especially after 25 days . I hopeDateTime.Utc.Tickscan be more reliable.