id in pre_get_shortlink can be zero #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blog post so the id needs to come from the post instead. Otherwise wordpress will not serve the youlrs url in the shortlink meta tag and http header.
|
Yes! I changed that line, and it worked on my end! Thanks! I pored over that function (I had isolated it as the culprit, but couldn't figure out what was causing it to fail back to $shortlink) Thanks jasgrlpen! |
|
My apologies for the [very] late reply here. I finally have some time to get back to this so I'll be looking at this PR over the weekend |
ChrisWiegman
added a commit
that referenced
this pull request
Mar 16, 2015
id in pre_get_shortlink can be zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$id in function pre_get_shortlink is 0 if it's called for the current blog post so the id needs to come from the post instead. Otherwise wordpress will not serve the youlrs url in the shortlink meta tag and http header.