Store response data from sent webmentions

[aarongustafson]

This bubbled up in #16. Should be easy enough.

It might also make sense to combine the (currently) two separate "outgoing" & "sent" webmentions files and track all of the details in one spot (as opposed ot having to work across two files.

[aarongustafson]

Integrating the webmention gem allows for this more easily. To make it happen thought, I need to do a few things:

• Write a sent webmentions migration script
• Figure out the best way to store responses
• Implement the change

[aarongustafson]

@miklb @martymcguire Are you just looking for me to store the response body or do you want headers and such too?

[miklb]

@aarongustafson For me the response body would be enough.

[martymcguire]

Same. There is a possible use case for storing HTTP result codes if there is an error fetching the content, but I don't currently try to use it, so 🤷‍♂️

…

On Jul 6, 2017 4:47 PM, "Michael Bishop" ***@***.***> wrote: @aarongustafson <https://github.com/aarongustafson> For me the response body would be enough. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA5tABEyQsySpGf6C9mOFwT9yBObcCrks5sLUfogaJpZM4OFjya> .

[miklb]

agreed the response code would be handy for debugging.

[aarongustafson]

So… assuming there’s not an location or server error, the response should provide an error object in the JSON, so that would get passed into the response body. The way I have things set up (and the way the webmentions gem processes the response), any failure will result in a false return. I currently have a false value as the default state that indicates a URL has not been mentioned. Storing false after a failed webmention would essentially keep it alive for the next run of the command. That sound good?

Here’s a look at the new, combined, format for outgoing webmentions with 3 failed webmentions and one success:

---
https://www.aaron-gustafson.com/jekyll/update/2017/06/20/welcome-to-jekyll.html:
  https://jekyllrb.com/docs/home: false
  https://github.com/jekyll/jekyll: false
  https://talk.jekyllrb.com/: false
  http://webmention.io/:
    status: queued
    summary: Webmention was queued for processing
    location: https://webmention.io/pingback/webmention/fZm5CkgNN6yuFWnc9NXw
    source: https://www.aaron-gustafson.com/jekyll/update/2017/06/20/welcome-to-jekyll.html
    target: http://webmention.io/

That work for you all?

[aarongustafson]

It’s worth noting that, for legacy purposes, I am adding a function to upgrade from the old two-file setup (queued and sent) to the combined file. For any webmentions that have been sent prior to the upgrade, I was planning to have the value be an empty string "". Any thoughts on that?

[aarongustafson]

agreed the response code would be handy for debugging.

I have some logs running during the build to let you know what’s going on:

[jekyll-webmention_io] Looking for webmention endpoint at https://jekyllrb.com/docs/home
[jekyll-webmention_io] No webmention endpoint at https://jekyllrb.com/docs/home
[jekyll-webmention_io] Looking for webmention endpoint at https://github.com/jekyll/jekyll
[jekyll-webmention_io] No webmention endpoint at https://github.com/jekyll/jekyll
[jekyll-webmention_io] Looking for webmention endpoint at https://talk.jekyllrb.com/
[jekyll-webmention_io] No webmention endpoint at https://talk.jekyllrb.com/
[jekyll-webmention_io] Looking for webmention endpoint at http://webmention.io/
[jekyll-webmention_io] Sending webmention of http://webmention.io/ in https://www.aaron-gustafson.com/
jekyll/update/2017/06/20/welcome-to-jekyll.html to https://webmention.io/pingback/webmention

I will likely slim these down for production and limit it to successes and failures an webmentioning only rather than reporting missing endpoints and such.

[miklb]

👍

I recall seeing the logging commented out in the old plugin, was helpful for me when I was debugging some things.

Here's an example of how I was dumping a raw response from bridgy to a json data file so your example definitely looks cleaner. My hacked together Rakefile that generated that.

Mind you I switched away from Jekyll about 6 months ago, but intend to pick it back up for a new site soon, so will be able to dig in more.

Can't thank you enough for picking this back up and putting in so much work to create the gem.