Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you like to configure how often the plugin looks for webmentions? #31

Closed
aarongustafson opened this issue Jun 26, 2017 · 12 comments
Closed
Labels

Comments

@aarongustafson
Copy link
Owner

Just wondering if it might be useful for speeding things up when you are debugging a build. Could be a configuration option like skip_webmention_collection_for and take a number of days as an argument.

@miklb
Copy link

miklb commented Jun 26, 2017

I think that would be useful, and if I'm reading correctly, an option would be to only check for webmentions for last X days? A 12 year old blog with some crufty links from the early days don't really need to be checked in my own anecdotal experience.

@aarongustafson
Copy link
Owner Author

aarongustafson commented Jun 26, 2017

Actually I was thinking about pausing all lookups for a period of time. It
might be possible to add some advanced config down the line to check older
posts less frequently. Something like

webmentions:
  throttle_checks:
    last_year: daily
    older: monthly

It’s possible. It’d be interesting to see if folks would be interested in
that.

@miklb
Copy link

miklb commented Jun 26, 2017

Actually I was thinking about pausing all lookups for a period of time

👍 definitely would be nice for local dev.

My build times had gotten really long & I was basically attributing it to all the links/posts it was checking. I'm about to do another Jekyll site for small project and look forward to testing out the new gem. Thanks for all the work on it.

@aarongustafson
Copy link
Owner Author

I went ahead and added the basic pause in 2.1.0: https://github.com/aarongustafson/jekyll-webmention_io#pausing-lookups

@0xdevalias
Copy link
Contributor

I'd like throw a +1 in for 'don't do older posts'. Even if it's just a really simple thing like "don't check before date X"

@aarongustafson
Copy link
Owner Author

aarongustafson commented Jul 17, 2017 via email

@0xdevalias
Copy link
Contributor

0xdevalias commented Jul 17, 2017 via email

@aarongustafson
Copy link
Owner Author

I am going to begin working on this, but just an FYI: I have implemented since_id with webmention.io in PR #38, so the processing time should be greatly reduced now.

@aarongustafson
Copy link
Owner Author

I am working on this feature right now. First pass is in the throttle_lookups branch. I am traveling right now and don't have my usual laptop with me, so I need to wait to get home to test, but if you'd like to beta it, feel free. Here are the _config.yml options:

  • throttle_lookups - hash for the config
  • Timeframes: last_week, last_month, last_year, older
  • Supported values: daily | weekly | monthly | yearly | every X day/week/month/year(s)

This should let you get crazy granular:

webmentions:
  throttle_lookups:
    last_week: daily
    last_month: weekly
    last_year: every 2 weeks
    older: monthly

If you get a chance to try it out, I have the logging on by default right now so we can see if it is working as expected. I should be able to test it within Jekyll by Monday at the latest.

@aarongustafson
Copy link
Owner Author

Sorry for the delay. I’ve run it through the test site and so far so good. Gonna try it on my own site now.

@aarongustafson
Copy link
Owner Author

Looks good and damn does it speed things up! I’ll add the details to the docs and bump to 2.7.0.

@0xdevalias
Copy link
Contributor

Sounds great! Haven't touched my blog for a bit, but might get a chance this weekend so will try it then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants