JekyllWebmentionIO.js, why source folder? #41
Comments
|
The reason I did that was to enable folks to modify the JS source if they wanted to. Also to allow them to use their own bundlers (I use Gulp, for instance). I can make it configurable if you would like. Maybe by setting |
|
That makes sense. Yeah, the ability to have it automagically pass through would be good for me.
What would be a usecase for needing to modify it manually?
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Aaron Gustafson <notifications@github.com>
Sent: Tuesday, July 18, 2017 2:23:41 AM
To: aarongustafson/jekyll-webmention_io
Cc: alias1; Author
Subject: Re: [aarongustafson/jekyll-webmention_io] JekyllWebmentionIO.js, why source folder? (#41)
The reason I did that was to enable folks to modify the JS source if they wanted to. Also to allow them to use their own bundlers (I use Gulp, for instance).
I can make it configurable if you would like. Maybe by setting js.destination to false?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#41 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAuA4_RR0kisUu58HF13B7F7ofapgUGrks5sO4lKgaJpZM4OYIcm>.
|
|
I will look into the pass-through. Manual modification might be necessary if you use a custom HTML template and need to tweak the JS. After publishing & modifying it, you’d want to turn off the auto-build. Mostly it’s for tools like Webpack, Gulp & Grunt though. |
|
That makes sense |
|
Ok, I tried to make it work and in order to get Jekyll to load the static file into the destination folder as part of the Jekyll build, the file needs to exist in the source folder. I tried making it work without it and I also tried removing the file after processing and neither worked (Ruby errors). Sorry, but it looks like you’re going to have to live with a file being output. That said, you can totally configure where it’s going to be put. |
|
Did you look at static file generators and the code I used in my original gem version? My version reads the file from the gem source and writes it into the built site, no need to exist in the source.
Can link/copy the code here if you need (or just look at the gem branch on my fork of this project)
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Aaron Gustafson <notifications@github.com>
Sent: Thursday, July 20, 2017 12:35:44 AM
To: aarongustafson/jekyll-webmention_io
Cc: alias1; Author
Subject: Re: [aarongustafson/jekyll-webmention_io] JekyllWebmentionIO.js, why source folder? (#41)
Ok, I tried to make it work and in order to get Jekyll to load the static file into the destination folder as part of the Jekyll build, the file needs to exist in the source folder. I tried making it work without it and I also tried removing the file after processing and neither worked (Ruby errors). Sorry, but it looks like you’re going to have to live with a file being output.
That said, you can totally configure where it’s going to be put<https://github.com/aarongustafson/jekyll-webmention_io#the-javascript-file>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#41 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAuA45WmXN_ahLDWslc8LN49Bqns-1oUks5sPhQSgaJpZM4OYIcm>.
|
|
I'll take a look.
…On Jul 19, 2017 4:17 PM, "alias1" ***@***.***> wrote:
Did you look at static file generators and the code I used in my original
gem version? My version reads the file from the gem source and writes it
into the built site, no need to exist in the source.
Can link/copy the code here if you need (or just look at the gem branch on
my fork of this project)
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Aaron Gustafson ***@***.***>
Sent: Thursday, July 20, 2017 12:35:44 AM
To: aarongustafson/jekyll-webmention_io
Cc: alias1; Author
Subject: Re: [aarongustafson/jekyll-webmention_io] JekyllWebmentionIO.js,
why source folder? (#41)
Ok, I tried to make it work and in order to get Jekyll to load the static
file into the destination folder as part of the Jekyll build, the file
needs to exist in the source folder. I tried making it work without it and
I also tried removing the file after processing and neither worked (Ruby
errors). Sorry, but it looks like you’re going to have to live with a file
being output.
That said, you can totally configure where it’s going to be put<
https://github.com/aarongustafson/jekyll-webmention_io#the-javascript-file
>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/
aarongustafson/jekyll-webmention_io#41#issuecomment-316407332>, or
mute the thread<https://github.com/notifications/unsubscribe-
auth/AAuA45WmXN_ahLDWslc8LN49Bqns-1oUks5sPhQSgaJpZM4OYIcm>.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEn2FR26BNHSr4PSoUsEZ3JLzzAuhWdks5sPmRxgaJpZM4OYIcm>
.
|
|
Link for reference (also at the top of this thread): https://github.com/alias1/jekyll-webmention_io/blob/convert-to-gem/lib/jekyll-webmention-io/webmention_js_generator.rb And the relevant docs: https://jekyllrb.com/docs/plugins/#generators |
|
2.6.0 includes the |
Just curious, why're you generating the
JekyllWebmentionIO.jsinto the source folder? I think in my original gem version (would have to check), I used a generator to just make it go straight into the 'build' folder when the site is generated. No need to clutter up the source that way.See: https://github.com/alias1/jekyll-webmention_io/blob/convert-to-gem/lib/jekyll-webmention-io/webmention_js_generator.rb
The text was updated successfully, but these errors were encountered: