Development #128
Merged
Development #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Install-VcRedist to use the output from Save-VcRedist and remove -Path parameter
Fix an issue sending the VcList object to Install-VcRedist via the pipeline
Update MDT functions to support output object from Save-VcRedist
Update Import-VcConfigMgrApplication with support for -VcList with path properties
Update function to use Path property on VcRedist object
Update filtering and valid inputs into -Release parameter
Rename variables, add unsupported Redists to tests
Update syntax for VcRedist 4.1
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 75.60% 76.59% +0.98%
==========================================
Files 24 24
Lines 791 786 -5
==========================================
+ Hits 598 602 +4
+ Misses 193 184 -9
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates functions to remove the
-Pathparameter and adds aPathproperty to the output of each function. This simplifies the code base and syntax required by each function.Address #127
Refer to #123
VcRedist
4.0will provide mostly under-the-hood code improvements; however, VcRedist4.1will introduce two breaking changes:Install-VcRedist,New-VcMdtApplication,New-VcConfigMgrApplication,New-VcIntuneApplicationetc., will require output fromSave-VcRedistinstead ofGet-VcList. This will be done to simplify determining the paths to the downloaded vcredist.exe installers -Get-VcList | Save-VcRedistreturns aPathproperty which means that a-Pathparameter will not be required by other functions. This change will require scripts to be updated