Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding config options for delays and timeouts #245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CSdread
Copy link

@CSdread CSdread commented Apr 27, 2023

Adds two configuration options:

  1. request_timeout which controls the timeout for requests to the bond bridge, this solves the timeout issue on initialization of the accessories on first startup
  2. delay_in_seconds which controls the delay between issuing commands through the bond bridge. When there are a lot of shades or accessories in a scene commands can get lost due to quantity in a short period of time.

The defaults keep behavior as it is now, but allows for tuning to make things work. These changes are required for the plugin to function with a Bond Bridge Pro and 24 shades with scenes that contain almost all of those shades.

@clifton
Copy link

clifton commented Sep 27, 2023

hi @aarons22 im also running into a closely related issue that can be similarly solved: https://forum.bondhome.io/t/need-to-hold-repeat-rf-signal-for-a-few-seconds/1059

@aarons22
Copy link
Owner

hey @CSdread - thanks for putting this together. I took a look at your code and delay_in_seconds doesn't appear to be used anywhere beyond the config validation. Did you still need that or should it be removed?

"request_timeout": {
"title": "Timeout for requests to the bond bridge.",
"type": "number",
"default": 1000,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to maintain the existing values, you'll need to change this to 10000

Suggested change
"default": 1000,
"default": 10000,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants