Allow to get received shares

[JocelynDelalande]

Currently, there is no way to get the shares that I received.

I hacked arround that way to get those shares : 

class PatchedNextCloudAsync(NextCloudAsync):
    async def get_all_shares(self):

        return await self.ocs_query(
            method='GET',
            sub='/ocs/v2.php/apps/files_sharing/api/v1/shares',
            data=dict(shared_with_me='true')
        )

But I think the code base may implement it somehow nicer than my ugly hack.

(sadly, this param is undocumented in ocs API doc)

[aaronsegura]

https://github.com/nextcloud/server/blob/082e85f6daf06bb77c175eb8c6c85a02f7f7bd6f/apps/files_sharing/openapi.json#L1619

Looks like the include_tags parameter is also undocumented.

[aaronsegura]

I modified the get_file_shares function to allow for these parameters, but I'm unable to test right now. Can you checkout the shared-with-me branch and let me know if it works for you?

[aaronsegura]

Nevermind, I was able to test it. It works! Will merge and cut a new release momentarily.

[aaronsegura]

https://pypi.org/project/nextcloud-async/0.0.10/

[JocelynDelalande]

Youhou, thanks !

[JocelynDelalande]

IMHO, all those args should be offered in get_all_shares() also

To stick more closely to the API, maybe get_shares() may accept a None value as « path » arg and get_all_shares() turned into a pass-through to get_all_shares() with path=None ?

And maybe get_all_shares() can be deprecated ?

[aaronsegura]

Makes sense. They both use the same endpoint. I think I was just following along with the API documentation when I made them both. If I had thought about it I probably would have done what you're recommending.

Changes in master

Don't see the need for a new release to be cut, but I will if you want one.

[JocelynDelalande]

Not needed here neither. Thanks for asking ! Le 19 février 2025 14:47:03 GMT+01:00, Aaron Segura ***@***.***> a écrit :

…

aaronsegura left a comment (aaronsegura/nextcloud-async#30) Makes sense. They both use the same endpoint. I think I was just following along with the API documentation when I made them both. If I had thought about it I probably would have done what you're recommending. [Changes in master ](e0cf491) Don't see the need for a new release to be cut, but I will if you want one. -- Reply to this email directly or view it on GitHub: #30 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>