Merge pull request #1003 from ChristopherMann/yaml-converter-override

Support YamlConverterAttribute in attribute overrides +semver:feature
aaubry · Nov 10, 2024 · 1055eb7 · 1055eb7
2 parents 7923dd8 + 2eb9023
commit 1055eb7
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 1 deletion.
diff --git a/YamlDotNet.Test/Serialization/TypeConverterAttributeTests.cs b/YamlDotNet.Test/Serialization/TypeConverterAttributeTests.cs
@@ -29,6 +29,45 @@ namespace YamlDotNet.Test.Serialization
 {
     public class TypeConverterAttributeTests
     {
+        [Fact]
+        public void TestConverterInAttributeOverride_Deserializes()
+        {
+            var deserializer = new DeserializerBuilder()
+                .WithAttributeOverride<OuterClassWithoutAttribute>(
+                    c => c.Value,
+                    new YamlConverterAttribute(typeof(AttributedTypeConverter)))
+                .WithTypeConverter(new AttributedTypeConverter())
+                .Build();
+            var yaml = @"Value:
+  abc: def";
+            var actual = deserializer.Deserialize<OuterClassWithoutAttribute>(yaml);
+            Assert.Equal("abc", actual.Value.Key);
+            Assert.Equal("def", actual.Value.Value);
+        }
+
+        [Fact]
+        public void TestConverterInAttributeOverride_Serializes()
+        {
+            var serializer = new SerializerBuilder()
+                .WithAttributeOverride<OuterClassWithoutAttribute>(
+                    c => c.Value,
+                    new YamlConverterAttribute(typeof(AttributedTypeConverter)))
+                .WithTypeConverter(new AttributedTypeConverter())
+                .Build();
+            var o = new OuterClassWithoutAttribute
+            {
+                Value = new ValueClass
+                {
+                    Key = "abc",
+                    Value = "def"
+                }
+            };
+            var actual = serializer.Serialize(o).NormalizeNewLines().TrimNewLines();
+            var expected = @"Value:
+  abc: def".NormalizeNewLines().TrimNewLines();
+            Assert.Equal(expected, actual);
+        }
+
         [Fact]
         public void TestConverterOnAttribute_Deserializes()
         {
@@ -94,6 +133,11 @@ public class OuterClass
             public ValueClass Value { get; set; }
         }
 
+        public class OuterClassWithoutAttribute
+        {
+            public ValueClass Value { get; set; }
+        }
+
         public class ValueClass
         {
             public string Key { get; set; }

diff --git a/YamlDotNet/Serialization/YamlAttributeOverridesInspector.cs b/YamlDotNet/Serialization/YamlAttributeOverridesInspector.cs
@@ -81,7 +81,8 @@ public Type? TypeOverride
                 set { baseDescriptor.TypeOverride = value; }
             }
 
-            public Type? ConverterType => baseDescriptor.ConverterType;
+            public Type? ConverterType =>
+                GetCustomAttribute<YamlConverterAttribute>()?.ConverterType ?? baseDescriptor.ConverterType;
 
             public int Order
             {