perf: Optimize number parse logics #1007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
commented
Nov 10, 2024
| [InlineData(System.Int32.MinValue)] | ||
| [InlineData(System.Int32.MaxValue)] | ||
| [InlineData(System.Int64.MinValue)] | ||
| [InlineData(System.Int64.MaxValue)] |
There was a problem hiding this comment.
UnitTest for ulong is not included.
Because ulong code path is not seems not be used.
Hex/Octal number representation is same for long/ulong and these number is always parsed as long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix following issues.
1. Change number checks to more strict regex
It's discussed at #990 (comment)
When parsing scalar values. whitespaces are already ignored by scanner.
So there is no needs using
partial regex match.2. Change Hex string format parse logics not to throw exceptions
Same as integer/float string format. (That is fixed at #990)