Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint config #117

Merged
merged 2 commits into from
Mar 8, 2021
Merged

fix: eslint config #117

merged 2 commits into from
Mar 8, 2021

Conversation

alexandre-abrioux
Copy link
Contributor

@alexandre-abrioux alexandre-abrioux commented Mar 8, 2021

cherry-picked from #114

I had to fix the eslint config to be able to commit because, as you can see here in the CI the command yarn lint is broken.

The issue comes from the fact that prettier/@typescript-eslint is still used in the project while it has been deprecated (see here).

However, I could not make it work by just modifying the .eslintrc.json, I think it is due to this issue: jaredpalmer/tsdx#498 (comment). tsdx doesn't seem to take into account the extends part of the .eslintrc.json config file. I had to migrate the config to the package.json file. It works for me now!

as suggested by @sakulstra in #114 (comment)

would you mind reopening a pr, cherry picking the lint changes?

@sakulstra sakulstra merged commit 5638f5f into aave:master Mar 8, 2021
@sakulstra
Copy link
Contributor

thx for taking the time @alexandre-abrioux!

@alexandre-abrioux alexandre-abrioux deleted the fix-eslint branch March 8, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants