Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHO CCIP 1.5 Maintenance Upgrade #15

Closed
wants to merge 28 commits into from
Closed

Conversation

DhairyaSethi
Copy link
Member

@DhairyaSethi DhairyaSethi commented Oct 18, 2024

Copy link

height bot commented Oct 18, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

lib/aave-ccip Outdated
Copy link

@miguelmtzinf miguelmtzinf Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update with final commit

Copy link

github-actions bot commented Oct 21, 2024

Foundry report

forge 0.2.0 (d2ed15d 2024-11-04T00:23:16.090720498Z)
Build log
Compiling 337 files with Solc 0.8.20
Solc 0.8.20 finished in 154.12s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> lib/aave-helpers/src/swaps/AaveSwapper.sol:146:5:
    |
146 |     address erc20Token
    |     ^^^^^^^^^^^^^^^^^^

Warning (2018): Function state mutability can be restricted to pure
   --> lib/aave-helpers/src/swaps/AaveSwapper.sol:145:3:
    |
145 |   function maxRescue(
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
   --> lib/aave-helpers/src/ProtocolV2TestBase.sol:663:3:
    |
663 |   function _logReserveConfig(ReserveConfig memory config) internal view {
    |   ^ (Relevant source part starts here and spans across multiple lines).

| Contract                                                            | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|---------------------------------------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveGovernanceV2                                                    |               44 |                94 |             24,532 |              49,058 |
| AaveSafetyModule                                                    |               44 |                94 |             24,532 |              49,058 |
| AaveSwapper                                                         |            5,555 |             5,992 |             19,021 |              43,160 |
| AaveV2Avalanche                                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV2AvalancheAssets                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV2Avalanche_ReserveFactorUpdatesMidOctober_20241004             |              988 |             1,017 |             23,588 |              48,135 |
| AaveV2Avalanche_UpdateLegacyGuardian_20241016                       |              348 |               486 |             24,228 |              48,666 |
| AaveV2Ethereum                                                      |               44 |                94 |             24,532 |              49,058 |
| AaveV2EthereumAMM                                                   |               44 |                94 |             24,532 |              49,058 |
| AaveV2EthereumAMMAssets                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV2EthereumAMM_UpdateLegacyGuardian_20241016                     |              348 |               486 |             24,228 |              48,666 |
| AaveV2EthereumAssets                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV2Ethereum_ReserveFactorUpdatesMidOctober_20241004              |              988 |             1,017 |             23,588 |              48,135 |
| AaveV2Ethereum_UpdateLegacyGuardian_20241016                        |              348 |               486 |             24,228 |              48,666 |
| AaveV2Polygon                                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV2PolygonAssets                                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV2Polygon_ReserveFactorUpdatesMidOctober_20241004               |            2,384 |             2,454 |             22,192 |              46,698 |
| AaveV2Polygon_UpdateLegacyGuardian_20241016                         |              348 |               486 |             24,228 |              48,666 |
| AaveV3Arbitrum                                                      |               44 |                94 |             24,532 |              49,058 |
| AaveV3ArbitrumAssets                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3ArbitrumEModes                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3ArbitrumExternalLibraries                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV3Arbitrum_GHOCCIP150Upgrade_20241021                           |           12,097 |            12,126 |             12,479 |              37,026 |
| AaveV3Arbitrum_GHOStewardV2Upgrade_20241007                         |            1,360 |             1,389 |             23,216 |              47,763 |
| AaveV3Arbitrum_ReserveFactorUpdatesMidOctober_20241004              |            3,227 |             3,297 |             21,349 |              45,855 |
| AaveV3Arbitrum_RiskStewardPhase2_20240805                           |              307 |               336 |             24,269 |              48,816 |
| AaveV3Arbitrum_UpdateLegacyGuardian_20241016                        |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Avalanche                                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV3AvalancheAssets                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV3AvalancheEModes                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV3AvalancheExternalLibraries                                    |               44 |                94 |             24,532 |              49,058 |
| AaveV3Avalanche_RiskStewardPhase2_20240805                          |              178 |               206 |             24,398 |              48,946 |
| AaveV3Avalanche_UpdateLegacyGuardian_20241016                       |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3BNB                                                           |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNBAssets                                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNBEModes                                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNBExternalLibraries                                          |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNB_OnboardWstETHToAaveV3OnBNBChain_20241030                  |            5,561 |             5,632 |             19,015 |              43,520 |
| AaveV3BNB_RiskStewardPhase2_20240805                                |              178 |               206 |             24,398 |              48,946 |
| AaveV3BNB_UpdateLegacyGuardian_20241016                             |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Base                                                          |               44 |                94 |             24,532 |              49,058 |
| AaveV3BaseAssets                                                    |               44 |                94 |             24,532 |              49,058 |
| AaveV3BaseEModes                                                    |               44 |                94 |             24,532 |              49,058 |
| AaveV3BaseExternalLibraries                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV3Base_IncreaseCbBTCSupplyCaps_20241004                         |            3,146 |             3,216 |             21,430 |              45,936 |
| AaveV3Base_ReserveFactorUpdatesMidOctober_20241004                  |            3,223 |             3,293 |             21,353 |              45,859 |
| AaveV3Base_RiskStewardPhase2_20240805                               |              178 |               206 |             24,398 |              48,946 |
| AaveV3Base_UpdateLegacyGuardian_20241016                            |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Ethereum                                                      |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumAssets                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEModes                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFi                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFiAssets                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFiEModes                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFiExternalLibraries                              |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFi_RiskStewardPhase2_20240805                    |              178 |               206 |             24,398 |              48,946 |
| AaveV3EthereumExternalLibraries                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLido                                                  |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLidoAssets                                            |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLidoEModes                                            |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLidoExternalLibraries                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLido_OnboardEzETHToLidoInstance_20241021              |            6,194 |             6,265 |             18,382 |              42,887 |
| AaveV3EthereumLido_RiskStewardPhase2_20240805                       |              178 |               206 |             24,398 |              48,946 |
| AaveV3EthereumLido_WstETHSlope1UoptimalUpdate_20241001              |            3,250 |             3,320 |             21,326 |              45,832 |
| AaveV3Ethereum_AaveBGDPhase4_20241025                               |            1,407 |             1,436 |             23,169 |              47,716 |
| AaveV3Ethereum_AaveCertoraContinuousSecurityServices_20241014       |            1,567 |             1,596 |             23,009 |              47,556 |
| AaveV3Ethereum_ChaosLabsAaveRiskManagementServiceRenewal_20241012   |            1,255 |             1,284 |             23,321 |              47,868 |
| AaveV3Ethereum_FixUSDSBorrowRateToMatchSkySavingsRate_20241022      |            3,238 |             3,308 |             21,338 |              45,844 |
| AaveV3Ethereum_GHOCCIP150Upgrade_20241021                           |           14,293 |            14,322 |             10,283 |              34,830 |
| AaveV3Ethereum_GHOStewardV2Upgrade_20241007                         |            2,895 |             2,924 |             21,681 |              46,228 |
| AaveV3Ethereum_IncreaseCbBTCSupplyCaps_20241004                     |            3,150 |             3,220 |             21,426 |              45,932 |
| AaveV3Ethereum_IncreaseUSDSBorrowRateToMatchSkySavingsRate_20241016 |            3,239 |             3,309 |             21,337 |              45,843 |
| AaveV3Ethereum_RenewLlamaRiskAsRiskServiceProvider_20241013         |            1,068 |             1,097 |             23,508 |              48,055 |
| AaveV3Ethereum_RiskStewardPhase2_20240805                           |              307 |               336 |             24,269 |              48,816 |
| AaveV3Ethereum_StkGHOIncentivesQ4_20241029                          |            1,458 |             1,487 |             23,118 |              47,665 |
| AaveV3Ethereum_UpdateLegacyGuardian_20241016                        |            1,062 |             1,413 |             23,514 |              47,739 |
| AaveV3Gnosis                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3GnosisAssets                                                  |               44 |                94 |             24,532 |              49,058 |
| AaveV3GnosisEModes                                                  |               44 |                94 |             24,532 |              49,058 |
| AaveV3GnosisExternalLibraries                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV3Gnosis_ReserveFactorUpdatesMidOctober_20241004                |            3,225 |             3,295 |             21,351 |              45,857 |
| AaveV3Gnosis_RiskStewardPhase2_20240805                             |              178 |               206 |             24,398 |              48,946 |
| AaveV3Gnosis_UpdateLegacyGuardian_20241016                          |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Metis                                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV3MetisAssets                                                   |               44 |                94 |             24,532 |              49,058 |
| AaveV3MetisEModes                                                   |               44 |                94 |             24,532 |              49,058 |
| AaveV3MetisExternalLibraries                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3Metis_RiskStewardPhase2_20240805                              |              178 |               206 |             24,398 |              48,946 |
| AaveV3Metis_UpdateLegacyGuardian_20241016                           |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Optimism                                                      |               44 |                94 |             24,532 |              49,058 |
| AaveV3OptimismAssets                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3OptimismEModes                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3OptimismExternalLibraries                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV3Optimism_ReserveFactorUpdatesMidOctober_20241004              |            3,227 |             3,297 |             21,349 |              45,855 |
| AaveV3Optimism_RiskStewardPhase2_20240805                           |              178 |               206 |             24,398 |              48,946 |
| AaveV3Optimism_UpdateLegacyGuardian_20241016                        |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Polygon                                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV3PolygonAssets                                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV3PolygonEModes                                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV3PolygonExternalLibraries                                      |               44 |                94 |             24,532 |              49,058 |
| AaveV3Polygon_ReserveFactorUpdatesMidOctober_20241004               |            3,226 |             3,296 |             21,350 |              45,856 |
| AaveV3Polygon_RiskStewardPhase2_20240805                            |              178 |               206 |             24,398 |              48,946 |
| AaveV3Polygon_UpdateLegacyGuardian_20241016                         |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Scroll                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3ScrollAssets                                                  |               44 |                94 |             24,532 |              49,058 |
| AaveV3ScrollEModes                                                  |               44 |                94 |             24,532 |              49,058 |
| AaveV3ScrollExternalLibraries                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV3Scroll_RiskStewardPhase2_20240805                             |              178 |               206 |             24,398 |              48,946 |
| AaveV3Scroll_UpdateLegacyGuardian_20241016                          |            1,062 |             1,393 |             23,514 |              47,759 |
| Address                                                             |               44 |                94 |             24,532 |              49,058 |
| CCIPUtils                                                           |            4,968 |             5,021 |             19,608 |              44,131 |
| ChainHelpers                                                        |               44 |                94 |             24,532 |              49,058 |
| ChainIds                                                            |               44 |                94 |             24,532 |              49,058 |
| Client                                                              |              109 |               160 |             24,467 |              48,992 |
| CollectorUtils                                                      |               44 |                94 |             24,532 |              49,058 |
| ConfiguratorInputTypes                                              |               44 |                94 |             24,532 |              49,058 |
| ConfirmedOwner                                                      |              542 |               873 |             24,034 |              48,279 |
| ConfirmedOwnerWithProposal                                          |              542 |               901 |             24,034 |              48,251 |
| Create2Utils                                                        |              121 |               172 |             24,455 |              48,980 |
| Create2UtilsZkSync                                                  |              104 |               155 |             24,472 |              48,997 |
| DataTypes                                                           |               44 |                94 |             24,532 |              49,058 |
| ERC1967Proxy                                                        |              129 |             1,179 |             24,447 |              47,973 |
| EngineFlags                                                         |               44 |                94 |             24,532 |              49,058 |
| EnumerableSet                                                       |               44 |                94 |             24,532 |              49,058 |
| Errors                                                              |            4,652 |             4,705 |             19,924 |              44,447 |
| GovV3Helpers                                                        |            2,517 |             2,570 |             22,059 |              46,582 |
| GovV3StorageHelpers                                                 |               44 |                94 |             24,532 |              49,058 |
| GovernanceGuardians                                                 |              292 |               345 |             24,284 |              48,807 |
| GovernanceV3Arbitrum                                                |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Avalanche                                               |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3BNB                                                     |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Base                                                    |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Ethereum                                                |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Gnosis                                                  |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Metis                                                   |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Optimism                                                |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Polygon                                                 |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3PolygonZkEvm                                            |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Scroll                                                  |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3ZkSync                                                  |               44 |                94 |             24,532 |              49,058 |
| IpfsUtils                                                           |               44 |                94 |             24,532 |              49,058 |
| MiscArbitrum                                                        |               44 |                94 |             24,532 |              49,058 |
| MiscAvalanche                                                       |               44 |                94 |             24,532 |              49,058 |
| MiscBNB                                                             |               44 |                94 |             24,532 |              49,058 |
| MiscBase                                                            |               44 |                94 |             24,532 |              49,058 |
| MiscEthereum                                                        |               44 |                94 |             24,532 |              49,058 |
| MiscGnosis                                                          |               44 |                94 |             24,532 |              49,058 |
| MiscMetis                                                           |               44 |                94 |             24,532 |              49,058 |
| MiscOptimism                                                        |               44 |                94 |             24,532 |              49,058 |
| MiscPolygon                                                         |               44 |                94 |             24,532 |              49,058 |
| MiscScroll                                                          |               44 |                94 |             24,532 |              49,058 |
| OwnerIsCreator                                                      |              542 |               790 |             24,034 |              48,362 |
| Payloads                                                            |               44 |                94 |             24,532 |              49,058 |
| PayloadsControllerUtils                                             |               44 |                94 |             24,532 |              49,058 |
| ProtocolGuardians                                                   |              292 |               345 |             24,284 |              48,807 |
| ProxyAdmin                                                          |            1,592 |             1,714 |             22,984 |              47,438 |
| ProxyHelpers                                                        |               44 |                94 |             24,532 |              49,058 |
| RateLimiter                                                         |               44 |                94 |             24,532 |              49,058 |
| RenewalV2BasePayload                                                |              348 |               595 |             24,228 |              48,557 |
| RenewalV3BasePayload                                                |            1,062 |             1,509 |             23,514 |              47,643 |
| ReserveConfiguration                                                |              128 |               179 |             24,448 |              48,973 |
| RewardsDataTypes                                                    |               44 |                94 |             24,532 |              49,058 |
| SafeERC20                                                           |               44 |                94 |             24,532 |              49,058 |
| StorageHelpers                                                      |               44 |                94 |             24,532 |              49,058 |
| StorageSlot                                                         |               44 |                94 |             24,532 |              49,058 |
| TestNetChainIds                                                     |               44 |                94 |             24,532 |              49,058 |
| TransparentUpgradeableProxy                                         |            2,000 |             3,429 |             22,576 |              45,723 |
| UpgradeableBurnMintTokenPool                                        |           10,059 |            10,841 |             14,517 |              38,311 |
| UpgradeableLockReleaseTokenPool                                     |           12,088 |            12,934 |             12,488 |              36,218 |
| WadRayMath                                                          |               44 |                94 |             24,532 |              49,058 |
Test success 🌈
No files changed, compilation skipped
2024-11-04T08:08:33.774804Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.1.4", "diff-snapshots", "./reports/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021_before.json", "./reports/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021_after.json", "-o", "./diffs/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021_before_AaveV3Arbitrum_GHOCCIP150Upgrade_20241021_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/aave-cli@1.1.8
"

Ran 13 tests for src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.t.sol:AaveV3Arbitrum_GHOCCIP150Upgrade_20241021_Test
[PASS] test_defaultProposalExecution() (gas: 51085492)
Logs:
  0xDA10009cBd5D07dd0CeCc66161FC93D7c9000da1
  0xf97f4df75117a78c1A5a0DBb814Af92458539FB4
  0xFF970A61A04b1cA14834A43f5dE4533eBDDB5CC8
  0x2f2a2543B76A4166549F7aaB2e75Bef0aefC5B0f
  0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
  0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9
  0xD22a58f79e9481D1a88e00c343885A588b34b68B
  0x5979D7b546E38E414F7E9822514be443A4800529
  0x3F56e0c36d275367b8C502090EDF38289b3dEa0d
  0xEC70Dcb4A1EFa46b8F2D97C310C9c4790ba5ffA8
  0x93b346b6BC2548dA6A1E7d98E9a421B42541425b
  0xaf88d065e77c8cC2239327C5EDb3A432268e5831
  0x17FC002b466eEc40DaE837Fc4bE5c67993ddBd6F
  0x912CE59144191C1204E64559FE8253a0e49E6548
  0x35751007a407ca6FEFfE80b3cB397736D2cf4dbe
  0x7dfF72693f6A4149b17e7C6314655f6A9F7c8B33
  E2E: Collateral DAI, TestAsset DAI
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: DAI, Amount: 1000199839928017617920
  WITHDRAW: DAI, Amount: 500099919964008808960
  WITHDRAW: DAI, Amount: 500099919964008808959
  BORROW: DAI, Amount 1000199839928017617920
  REPAY: DAI, Amount: 1000199839928017617920
  E2E: Collateral DAI, TestAsset LINK
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: LINK, Amount: 88983804947499555080
  WITHDRAW: LINK, Amount: 44491902473749777540
  WITHDRAW: LINK, Amount: 44491902473749777540
  BORROW: LINK, Amount 88983804947499555080
  REPAY: LINK, Amount: 88983804947499555080
  E2E: Collateral DAI, TestAsset USDC
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: USDC, Amount: 1000143040
  WITHDRAW: USDC, Amount: 500071520
  WITHDRAW: USDC, Amount: 500071520
  BORROW: USDC, Amount 1000143040
  REPAY: USDC, Amount: 1000143040
  E2E: Collateral DAI, TestAsset WBTC
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: WBTC, Amount: 1512570
  WITHDRAW: WBTC, Amount: 756285
  WITHDRAW: WBTC, Amount: 756286
  BORROW: WBTC, Amount 1512570
  REPAY: WBTC, Amount: 1512570
  E2E: Collateral DAI, TestAsset WETH
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: WETH, Amount: 412722880116158840
  WITHDRAW: WETH, Amount: 206361440058079420
  WITHDRAW: WETH, Amount: 206361440058079420
  BORROW: WETH, Amount 412722880116158840
  REPAY: WETH, Amount: 412722880116158840
  E2E: Collateral DAI, TestAsset USDT
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: USDT, Amount: 1001869117
  WITHDRAW: USDT, Amount: 500934558
  WITHDRAW: USDT, Amount: 500934560
  BORROW: USDT, Amount 1001869117
  REPAY: USDT, Amount: 1001869117
  E2E: Collateral DAI, TestAsset AAVE
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: AAVE, Amount: 7226122845397022596
  WITHDRAW: AAVE, Amount: 3613061422698511298
  WITHDRAW: AAVE, Amount: 3613061422698511298
  E2E: TestAsset EURS SKIPPED
  E2E: Collateral DAI, TestAsset wstETH
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: wstETH, Amount: 348915567090050816
  WITHDRAW: wstETH, Amount: 174457783545025408
  WITHDRAW: wstETH, Amount: 174457783545025409
  BORROW: wstETH, Amount 348915567090050816
  REPAY: wstETH, Amount: 348915567090050816
  E2E: TestAsset MAI SKIPPED
  E2E: Collateral DAI, TestAsset rETH
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: rETH, Amount: 368806263357155648
  WITHDRAW: rETH, Amount: 184403131678577824
  WITHDRAW: rETH, Amount: 184403131678577824
  BORROW: rETH, Amount 368806263357155648
  REPAY: rETH, Amount: 368806263357155648
  E2E: Collateral DAI, TestAsset LUSD
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: LUSD, Amount: 1005271240275508657194
  WITHDRAW: LUSD, Amount: 502635620137754328597
  WITHDRAW: LUSD, Amount: 502635620137754328597
  BORROW: LUSD, Amount 1005271240275508657194
  REPAY: LUSD, Amount: 1005271240275508657194
  E2E: Collateral DAI, TestAsset USDC
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: USDC, Amount: 1000143040
  WITHDRAW: USDC, Amount: 500071520
  WITHDRAW: USDC, Amount: 500071519
  BORROW: USDC, Amount 1000143040
  REPAY: USDC, Amount: 1000143040
  E2E: Collateral DAI, TestAsset FRAX
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: FRAX, Amount: 1003120467023999576923
  WITHDRAW: FRAX, Amount: 501560233511999788461
  WITHDRAW: FRAX, Amount: 501560233511999788463
  BORROW: FRAX, Amount 1003120467023999576923
  REPAY: FRAX, Amount: 1003120467023999576923
  E2E: Collateral DAI, TestAsset ARB
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: ARB, Amount: 1927658819810164159425
  WITHDRAW: ARB, Amount: 963829409905082079712
  WITHDRAW: ARB, Amount: 963829409905082079713
  BORROW: ARB, Amount 1927658819810164159425
  REPAY: ARB, Amount: 1927658819810164159425
  E2E: Collateral DAI, TestAsset weETH
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: weETH, Amount: 392632770186650304
  WITHDRAW: weETH, Amount: 196316385093325152
  WITHDRAW: weETH, Amount: 196316385093325151
  BORROW: weETH, Amount 392632770186650304
  REPAY: weETH, Amount: 392632770186650304
  E2E: Collateral DAI, TestAsset GHO
  SUPPLY: DAI, Amount: 100019983992801761792006
  SUPPLY: GHO, Amount: 1000000000000000000000
  WITHDRAW: GHO, Amount: 500000000000000000000
  WITHDRAW: GHO, Amount: 499999999999999999999
  BORROW: GHO, Amount 1000000000000000000000
  REPAY: GHO, Amount: 1000000000000000000000

[PASS] test_executeMessagePostCCIPMigration() (gas: 2775188)
[PASS] test_executeMessagePostCCIPMigrationViaLegacyOffRamp() (gas: 2775111)
[PASS] test_executeMessagePreCCIPMigration() (gas: 2360968)
[PASS] test_getProxyPool() (gas: 2286342)
[PASS] test_getRateLimitAdmin() (gas: 2284225)
[PASS] test_ownershipTransferOfGhoProxyPool() (gas: 2714447)
[PASS] test_proxyPoolCanOffRamp() (gas: 2387639)
[PASS] test_proxyPoolCanOnRamp() (gas: 2490331)
[PASS] test_sendMessagePostCCIPMigration() (gas: 3148824)
[PASS] test_sendMessagePreCCIPMigration() (gas: 2698159)
[PASS] test_stewardCanDisableRateLimit() (gas: 2316934)
[PASS] test_tokenPoolCannotBeInitializedAgain() (gas: 2293553)
Suite result: ok. 13 passed; 0 failed; 0 skipped; finished in 9.85s (9.82s CPU time)

Ran 1 test suite in 9.86s (9.85s CPU time): 13 tests passed, 0 failed, 0 skipped (13 total tests)
No files changed, compilation skipped

Ran 2 tests for src/20241021_Multi_GHOCCIP150Upgrade/AaveV3E2E_GHOCCIP150Upgrade_20241021.t.sol:AaveV3E2E_GHOCCIP150Upgrade_20241021_InFlightCCIPMigration
[PASS] test_SendFlowInFlightCCIPMigrationFromArb() (gas: 1431991)
[PASS] test_SendFlowInFlightCCIPMigrationFromEth() (gas: 1380627)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 219.65ms (17.92ms CPU time)

Ran 1 test for src/20241021_Multi_GHOCCIP150Upgrade/AaveV3E2E_GHOCCIP150Upgrade_20241021.t.sol:AaveV3E2E_GHOCCIP150Upgrade_20241021_PreCCIPMigration
[PASS] test_E2E() (gas: 958018)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 220.23ms (10.87ms CPU time)

Ran 3 tests for src/20241021_Multi_GHOCCIP150Upgrade/AaveV3E2E_GHOCCIP150Upgrade_20241021.t.sol:AaveV3E2E_GHOCCIP150Upgrade_20241021_PostCCIPMigration
[PASS] test_E2E() (gas: 1144069)
[PASS] test_ExecuteRevertsWithoutUpgrade() (gas: 882522)
[PASS] test_SendRevertsWithoutUpgrade() (gas: 1146133)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 227.95ms (26.35ms CPU time)

Ran 3 test suites in 244.25ms (667.82ms CPU time): 6 tests passed, 0 failed, 0 skipped (6 total tests)
No files changed, compilation skipped

Ran 12 tests for src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Ethereum_GHOCCIP150Upgrade_20241021.t.sol:AaveV3Ethereum_GHOCCIP150Upgrade_20241021_Test
[PASS] test_defaultProposalExecution() (gas: 229457578)
Logs:
  0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
  0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0
  0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599
  0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48
  0x6B175474E89094C44Da98b954EedeAC495271d0F
  0x514910771AF9Ca656af840dff83E8264EcF986CA
  0xBe9895146f7AF43049ca1c1AE358B0541Ea49704
  0xdAC17F958D2ee523a2206206994597C13D831ec7
  0xae78736Cd615f374D3085123A210448E74Fc6393
  0x5f98805A4E8be255a32880FDeC7F6728C6568bA0
  0xD533a949740bb3306d119CC777fa900bA034cd52
  0x9f8F72aA9304c8B593d555F12eF6589cC3A579A2
  0xC011a73ee8576Fb46F5E1c5751cA3B9Fe0af2a6F
  0xba100000625a3754423978a60c9317c58a424e3D
  0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984
  0x5A98FcBEA516Cf06857215779Fd812CA3beF1B32
  0xC18360217D8F7Ab5e7c516566761Ea12Ce7F9D72
  0x111111111117dC0aa78b770fA6A738034120C302
  0x853d955aCEf822Db058eb8505911ED77F175b99e
  0xD33526068D116cE69F19A9ee46F0bd304F21A51f
  0xAf5191B0De278C7286d6C7CC6ab6BB8A73bA2Cd6
  0xdeFA4e8a7bcBA345F687a2f1456F5Edd9CE97202
  0x3432B6A60D23Ca0dFCa7761B7ab56459D9C964D0
  0xf939E0A03FB07F59A73314E73794Be0E57ac1b4E
  0x6c3ea9036406852006290770BEdFcAbA0e23A0e8
  0xCd5fE23C85820F7B72D0926FC9b05b43E359b7ee
  0xf1C9acDc66974dFB6dEcB12aA385b9cD01190E38
  0x4c9EDD5852cd905f086C759E8383e09bff1E68B3
  0xA35b1B31Ce002FBF2058D22F30f95D405200A15b
  0x18084fbA666a33d37592fA2633fD49a74DD93a88
  0xcbB7C0000aB88B473b1f5aFd9ef808440eed33Bf
  0xdC035D45d973E3EC169d2276DDab16f1e407384F
  E2E: Collateral WETH, TestAsset WETH
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: WETH, Amount: 401751637137921337
  WITHDRAW: WETH, Amount: 200875818568960668
  WITHDRAW: WETH, Amount: 200875818568960669
  BORROW: WETH, Amount 401751637137921337
  REPAY: WETH, Amount: 401751637137921337
  E2E: Collateral WETH, TestAsset wstETH
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: wstETH, Amount: 339640487733277218
  WITHDRAW: wstETH, Amount: 169820243866638609
  WITHDRAW: wstETH, Amount: 169820243866638608
  BORROW: wstETH, Amount 339640487733277218
  REPAY: wstETH, Amount: 339640487733277218
  E2E: Collateral WETH, TestAsset WBTC
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: WBTC, Amount: 1489415
  WITHDRAW: WBTC, Amount: 744707
  WITHDRAW: WBTC, Amount: 744708
  BORROW: WBTC, Amount 1489415
  REPAY: WBTC, Amount: 1489415
  E2E: Collateral WETH, TestAsset USDC
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: USDC, Amount: 1000204231
  WITHDRAW: USDC, Amount: 500102115
  WITHDRAW: USDC, Amount: 500102117
  BORROW: USDC, Amount 1000204231
  REPAY: USDC, Amount: 1000204231
  E2E: Collateral WETH, TestAsset DAI
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: DAI, Amount: 1000250062515628907226
  WITHDRAW: DAI, Amount: 500125031257814453613
  WITHDRAW: DAI, Amount: 500125031257814453612
  BORROW: DAI, Amount 1000250062515628907226
  REPAY: DAI, Amount: 1000250062515628907226
  E2E: Collateral WETH, TestAsset LINK
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: LINK, Amount: 85109658505418956213
  WITHDRAW: LINK, Amount: 42554829252709478106
  WITHDRAW: LINK, Amount: 42554829252709478108
  BORROW: LINK, Amount 85109658505418956213
  REPAY: LINK, Amount: 85109658505418956213
  E2E: Collateral WETH, TestAsset AAVE
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: AAVE, Amount: 7042191421396648178
  WITHDRAW: AAVE, Amount: 3521095710698324089
  WITHDRAW: AAVE, Amount: 3521095710698324089
  E2E: Collateral WETH, TestAsset cbETH
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: cbETH, Amount: 370375779996707273
  WITHDRAW: cbETH, Amount: 185187889998353636
  WITHDRAW: cbETH, Amount: 185187889998353637
  BORROW: cbETH, Amount 370375779996707273
  REPAY: cbETH, Amount: 370375779996707273
  E2E: Collateral WETH, TestAsset USDT
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: USDT, Amount: 1000795632
  WITHDRAW: USDT, Amount: 500397816
  WITHDRAW: USDT, Amount: 500397815
  BORROW: USDT, Amount 1000795632
  REPAY: USDT, Amount: 1000795632
  E2E: Collateral WETH, TestAsset rETH
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: rETH, Amount: 358979177253074111
  WITHDRAW: rETH, Amount: 179489588626537055
  WITHDRAW: rETH, Amount: 179489588626537056
  BORROW: rETH, Amount 358979177253074111
  REPAY: rETH, Amount: 358979177253074111
  E2E: Collateral WETH, TestAsset LUSD
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: LUSD, Amount: 1002938137361544766239
  WITHDRAW: LUSD, Amount: 501469068680772383119
  WITHDRAW: LUSD, Amount: 501469068680772383121
  BORROW: LUSD, Amount 1002938137361544766239
  REPAY: LUSD, Amount: 1002938137361544766239
  E2E: Collateral WETH, TestAsset CRV
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: CRV, Amount: 4081632653061224489795
  WITHDRAW: CRV, Amount: 2040816326530612244897
  WITHDRAW: CRV, Amount: 2040816326530612244897
  BORROW: CRV, Amount 4081632653061224489795
  REPAY: CRV, Amount: 4081632653061224489795
  E2E: Collateral WETH, TestAsset MKR
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: MKR, Amount: 914089360269190209
  WITHDRAW: MKR, Amount: 457044680134595104
  WITHDRAW: MKR, Amount: 457044680134595106
  BORROW: MKR, Amount 914089360269190209
  REPAY: MKR, Amount: 914089360269190209
  E2E: Collateral WETH, TestAsset SNX
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: SNX, Amount: 683433570256971022416
  WITHDRAW: SNX, Amount: 341716785128485511208
  WITHDRAW: SNX, Amount: 341716785128485511208
  BORROW: SNX, Amount 683433570256971022416
  REPAY: SNX, Amount: 683433570256971022416
  E2E: Collateral WETH, TestAsset BAL
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: BAL, Amount: 531967462188896517656
  WITHDRAW: BAL, Amount: 265983731094448258828
  WITHDRAW: BAL, Amount: 265983731094448258829
  BORROW: BAL, Amount 531967462188896517656
  REPAY: BAL, Amount: 531967462188896517656
  E2E: Collateral WETH, TestAsset UNI
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: UNI, Amount: 128427406408527579785
  WITHDRAW: UNI, Amount: 64213703204263789892
  WITHDRAW: UNI, Amount: 64213703204263789892
  BORROW: UNI, Amount 128427406408527579785
  REPAY: UNI, Amount: 128427406408527579785
  E2E: Collateral WETH, TestAsset LDO
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: LDO, Amount: 939825474785262566655
  WITHDRAW: LDO, Amount: 469912737392631283327
  WITHDRAW: LDO, Amount: 469912737392631283328
  BORROW: LDO, Amount 939825474785262566655
  REPAY: LDO, Amount: 939825474785262566655
  E2E: Collateral WETH, TestAsset ENS
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: ENS, Amount: 58757697563920900970
  WITHDRAW: ENS, Amount: 29378848781960450485
  WITHDRAW: ENS, Amount: 29378848781960450485
  BORROW: ENS, Amount 58757697563920900970
  REPAY: ENS, Amount: 58757697563920900970
  E2E: Collateral WETH, TestAsset 1INCH
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: 1INCH, Amount: 3783840255042941478710
  WITHDRAW: 1INCH, Amount: 1891920127521470739355
  WITHDRAW: 1INCH, Amount: 1891920127521470739355
  BORROW: 1INCH, Amount 3783840255042941478710
  REPAY: 1INCH, Amount: 3783840255042941478710
  E2E: Collateral WETH, TestAsset FRAX
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: FRAX, Amount: 1003719170978953705269
  WITHDRAW: FRAX, Amount: 501859585489476852634
  WITHDRAW: FRAX, Amount: 501859585489476852635
  BORROW: FRAX, Amount 1003719170978953705269
  REPAY: FRAX, Amount: 1003719170978953705269
  E2E: Collateral WETH, TestAsset GHO
  SUPPLY: WETH, Amount: 40175163713792133702
  BORROW: GHO, Amount 1000000000000000000000
  REPAY: GHO, Amount: 1000000000000000000000
  E2E: Collateral WETH, TestAsset RPL
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: RPL, Amount: 92401784362356857311
  WITHDRAW: RPL, Amount: 46200892181178428655
  WITHDRAW: RPL, Amount: 46200892181178428655
  BORROW: RPL, Amount 92401784362356857311
  REPAY: RPL, Amount: 92401784362356857311
  E2E: Collateral WETH, TestAsset sDAI
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: sDAI, Amount: 896987843957949532790
  WITHDRAW: sDAI, Amount: 448493921978974766395
  WITHDRAW: sDAI, Amount: 448493921978974766395
  E2E: TestAsset STG SKIPPED
  E2E: TestAsset KNC SKIPPED
  E2E: TestAsset FXS SKIPPED
  E2E: Collateral WETH, TestAsset crvUSD
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: crvUSD, Amount: 1002745024532106887926
  WITHDRAW: crvUSD, Amount: 501372512266053443963
  WITHDRAW: crvUSD, Amount: 501372512266053443962
  BORROW: crvUSD, Amount 1002745024532106887926
  REPAY: crvUSD, Amount: 1002745024532106887926
  E2E: Collateral WETH, TestAsset PYUSD
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: PYUSD, Amount: 1000483513
  WITHDRAW: PYUSD, Amount: 500241756
  WITHDRAW: PYUSD, Amount: 500241758
  BORROW: PYUSD, Amount 1000483513
  REPAY: PYUSD, Amount: 1000483513
  E2E: Collateral WETH, TestAsset weETH
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: weETH, Amount: 382182586082254314
  WITHDRAW: weETH, Amount: 191091293041127157
  WITHDRAW: weETH, Amount: 191091293041127158
  BORROW: weETH, Amount 382182586082254314
  REPAY: weETH, Amount: 382182586082254314
  E2E: Collateral WETH, TestAsset osETH
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: osETH, Amount: 390080117354519819
  WITHDRAW: osETH, Amount: 195040058677259909
  WITHDRAW: osETH, Amount: 195040058677259909
  BORROW: osETH, Amount 390080117354519819
  REPAY: osETH, Amount: 390080117354519819
  E2E: Collateral WETH, TestAsset USDe
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: USDe, Amount: 999400429700209953042
  WITHDRAW: USDe, Amount: 499700214850104976521
  WITHDRAW: USDe, Amount: 499700214850104976522
  BORROW: USDe, Amount 999400429700209953042
  REPAY: USDe, Amount: 999400429700209953042
  E2E: Collateral WETH, TestAsset ETHx
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: ETHx, Amount: 384987459180582401
  WITHDRAW: ETHx, Amount: 192493729590291200
  WITHDRAW: ETHx, Amount: 192493729590291201
  BORROW: ETHx, Amount 384987459180582401
  REPAY: ETHx, Amount: 384987459180582401
  E2E: Collateral WETH, TestAsset sUSDe
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: sUSDe, Amount: 899679241858296470850
  WITHDRAW: sUSDe, Amount: 449839620929148235425
  WITHDRAW: sUSDe, Amount: 449839620929148235425
  E2E: Collateral WETH, TestAsset tBTC
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: tBTC, Amount: 14876286965060912
  WITHDRAW: tBTC, Amount: 7438143482530456
  WITHDRAW: tBTC, Amount: 7438143482530456
  BORROW: tBTC, Amount 14876286965060912
  REPAY: tBTC, Amount: 14876286965060912
  E2E: Collateral WETH, TestAsset cbBTC
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: cbBTC, Amount: 1487628
  WITHDRAW: cbBTC, Amount: 743814
  WITHDRAW: cbBTC, Amount: 743813
  BORROW: cbBTC, Amount 1487628
  REPAY: cbBTC, Amount: 1487628
  E2E: Collateral WETH, TestAsset USDS
  SUPPLY: WETH, Amount: 40175163713792133702
  SUPPLY: USDS, Amount: 1000250062515628907226
  WITHDRAW: USDS, Amount: 500125031257814453613
  WITHDRAW: USDS, Amount: 500125031257814453614
  BORROW: USDS, Amount 1000250062515628907226
  REPAY: USDS, Amount: 1000250062515628907226

[PASS] test_executeMessagePostCCIPMigration() (gas: 3257554)
[PASS] test_executeMessagePostCCIPMigrationViaLegacyOffRamp() (gas: 3259565)
[PASS] test_executeMessagePreCCIPMigration() (gas: 2894089)
[PASS] test_getProxyPool() (gas: 2694789)
[PASS] test_ownershipTransferOfGhoProxyPool() (gas: 3074191)
[PASS] test_proxyPoolCanOffRamp() (gas: 2907363)
[PASS] test_proxyPoolCanOnRamp() (gas: 2737468)
[PASS] test_sendMessagePostCCIPMigration() (gas: 3479971)
[PASS] test_sendMessagePreCCIPMigration() (gas: 3078785)
[PASS] test_stewardCanDisableRateLimit() (gas: 2725450)
[PASS] test_tokenPoolCannotBeInitializedAgain() (gas: 2702087)
Suite result: ok. 12 passed; 0 failed; 0 skipped; finished in 1.92s (1.89s CPU time)

Ran 1 test suite in 1.93s (1.92s CPU time): 12 tests passed, 0 failed, 0 skipped (12 total tests)

@DhairyaSethi DhairyaSethi marked this pull request as ready for review October 28, 2024 02:19
@DhairyaSethi DhairyaSethi force-pushed the new/ccip_1_5_maintenance branch from f19c6ff to 9507080 Compare October 30, 2024 15:06
executePayload(vm, address(proposal));

// we currently do not set the rate limit admin
assertEq(ghoTokenPool.getRateLimitAdmin(), address(0));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be done if pushing this AIP before GhoStewards upgrade

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from slack: plan to push GhoStewards upgrade before this (if not, we have to make sure bgd-labs#502 proposal uses the latest UpgradableBurnMint token pool implementation (which is yet to be merged on aave/ccip#18)
added test for steward's ability to disable rate limit bf4f3e5

@miguelmtzinf
Copy link

Closing in favor of bgd-labs#512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants