Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show optimal swap path #18

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

sakulstra
Copy link
Contributor

@sakulstra sakulstra commented Sep 27, 2021

currently the swap ui just shows the "worst possible outcome after slippage"

This pr, changes it so in addition to the "worst possible outcome" it also show the "predicted outcome".
Some design changes for the form are still missing.

info: backported from different repo, this will probably not be merged anytime soon as in v3 things change quite a bit

@sakulstra sakulstra mentioned this pull request Oct 18, 2021
sakulstra and others added 4 commits October 18, 2021 18:36
* fix: repay with collateral & swap styles

* fix: some smaller fixes

Co-authored-by: sakulstra <lukasstrassel@googlemail.com>
@sakulstra sakulstra force-pushed the feat/show-optimal-path branch from 4c9e5d0 to 4403f42 Compare October 18, 2021 16:55
@sakulstra sakulstra changed the title feat: show optimal path feat: show optimal swap path Jan 3, 2022
paulcodiny added a commit to paulcodiny/aave-ui that referenced this pull request Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants