Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: double token delegation #522

Merged
merged 9 commits into from
Apr 4, 2023
Merged

Conversation

JoaquinBattilana
Copy link
Member

No description provided.

@height
Copy link

height bot commented Mar 3, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

🎉 Canary Release
To install use
npm install @aave/math-utils@1.13.6-9058ba6343ad36108b5c865e0d7b7c9b8ed7530e.0+3ace885
npm install @aave/contract-helpers@1.13.6-9058ba6343ad36108b5c865e0d7b7c9b8ed7530e.0+3ace885

Copy link
Collaborator

@defispartan defispartan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New delegation service looks good!

There's a few small optimizations but these can wait until after #514. After 514, this service can be updated to follow the ActionBundle type which will move the signature generation + nonce check to utilities and remove the need to have a custom tx handler on the UI since this bundle supports multiple signatures for an action by default

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 Canary Release
To install use
npm install @aave/math-utils@1.13.7-b88354cb438cb57a75106e845f0ef0fac7becf70.0+b70b254
npm install @aave/contract-helpers@1.13.7-b88354cb438cb57a75106e845f0ef0fac7becf70.0+b70b254

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 Canary Release
To install use
npm install @aave/math-utils@1.13.7-32932ed5b76859ebcffa2aad6d62b4271850bb93.0+20ecf88
npm install @aave/contract-helpers@1.13.7-32932ed5b76859ebcffa2aad6d62b4271850bb93.0+20ecf88

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 Canary Release
To install use
npm install @aave/math-utils@1.13.7-43be4e0bee9f9803ba5440a79a94881ba8960c1f.0+97e9226
npm install @aave/contract-helpers@1.13.7-43be4e0bee9f9803ba5440a79a94881ba8960c1f.0+97e9226

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

🎉 Canary Release
To install use
npm install @aave/math-utils@1.13.7-b19c0cbf15ed215a672710093a09f6d1937e2a5e.0+dc86969
npm install @aave/contract-helpers@1.13.7-b19c0cbf15ed215a672710093a09f6d1937e2a5e.0+dc86969

@defispartan
Copy link
Collaborator

Waiting to test UI with new governance helper contract

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

🎉 Canary Release
To install use
npm install @aave/math-utils@1.13.7-f9c9354613157615f71e89cb7b75c444239a1cba.0+fd7fe79
npm install @aave/contract-helpers@1.13.7-f9c9354613157615f71e89cb7b75c444239a1cba.0+fd7fe79

@JoaquinBattilana JoaquinBattilana force-pushed the feat/double-token-delegation branch from f9c9354 to 16b777b Compare April 4, 2023 00:02
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

🎉 Canary Release
To install use
npm install @aave/math-utils@1.13.7-16b777b9f6ef9d8f2c0afcb45e35adeddacb3336.0+c91175a
npm install @aave/contract-helpers@1.13.7-16b777b9f6ef9d8f2c0afcb45e35adeddacb3336.0+c91175a

@defispartan defispartan merged commit f01d576 into master Apr 4, 2023
@defispartan defispartan deleted the feat/double-token-delegation branch April 4, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants