-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zero ltv transfer #820
fix: zero ltv transfer #820
Conversation
sakulstra
commented
Mar 6, 2023
•
edited
Loading
edited
- fix: disallow enabling 0ltv asset as collateral
- currently it is possible to enable collateral for a 0 ltv asset, which seems intended as 0ltv is mostly used for mitigation when a asset depegs to no longer allow borrows. By allowing to enable collateral, potentially a user could "up" his position with a 0ltv asset to force liquidators to liquidate 0ltv.
- fix: don't automatically activate collateral for assets received in isolation
- currently when receiving an isolated asset (via supply or transfer) it would be automatically enabled as collateral, which seems unintended
- feat: add new ISOLATED_COLLATERAL_SUPPLIER role
- in order to allow supply as collateral for certain contracts (e.g. migration tool) a new role is added, allowing supplies and transfers with the old behavior.
|
This PR looks good to me. The only thing that I do not like is the need of passing the |
fix: Fetch addressesProvider from AToken