-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set asset as collateral #569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
Rubilmax,
QGarchery,
Tristan22400 and
pakim249CAL
February 22, 2023 14:40
Tristan22400
suggested changes
Feb 22, 2023
This was
linked to
issues
Feb 23, 2023
…asset-as-collateral
pakim249CAL
reviewed
Feb 23, 2023
pakim249CAL
reviewed
Feb 23, 2023
QGarchery
previously requested changes
Feb 23, 2023
I'm trying to fix the CI but this is quite long 🫠 |
Tristan22400
previously approved these changes
Feb 24, 2023
Rubilmax
previously approved these changes
Mar 15, 2023
MerlinEgalite
dismissed stale reviews from Rubilmax and pakim249CAL
via
March 15, 2023 17:35
a57a7c0
…ho-aave-v3 into refactor/collateral-setters
MathisGD
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
Waiting for #680 to approve
QGarchery
previously approved these changes
Mar 15, 2023
pakim249CAL
previously approved these changes
Mar 15, 2023
Rubilmax
previously approved these changes
Mar 16, 2023
Tristan22400
previously approved these changes
Mar 16, 2023
Refactor collateral setters
MerlinEgalite
dismissed stale reviews from Tristan22400, Rubilmax, pakim249CAL, and QGarchery
via
March 16, 2023 10:00
84ab598
MerlinEgalite
requested review from
MathisGD,
Rubilmax,
QGarchery,
pakim249CAL and
Tristan22400
March 16, 2023 10:07
MathisGD
approved these changes
Mar 16, 2023
Rubilmax
approved these changes
Mar 16, 2023
QGarchery
approved these changes
Mar 16, 2023
Tristan22400
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Descrition
This PR covers the edge case related to the
LTV = 0
described here among other issues.What the PR is doing:
We are working on complementary remediations are not contract related such as:
Issue(s) fixed
This pull request:
setAssetAsCollateral
function to handleltv
to 0 #538