Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: withdraw and swap adapter #180

Merged
merged 6 commits into from
Aug 22, 2023
Merged

feat: withdraw and swap adapter #180

merged 6 commits into from
Aug 22, 2023

Conversation

grothem
Copy link
Contributor

@grothem grothem commented Aug 15, 2023

  • Adds in a new adapter that allows a user to withdraw an asset and swap it to a different asset. This is based on the existing liquidity swap adapter, but instead of depositing the swapped assets back into the pool, they are transferred to the user.

@height
Copy link

height bot commented Aug 15, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-13768" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@miguelmtzinf miguelmtzinf self-requested a review August 16, 2023 07:30
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.38% 🎉

Comparison is base (8f3380d) 55.78% compared to head (d8a1eed) 56.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   55.78%   56.16%   +0.38%     
==========================================
  Files          25       26       +1     
  Lines         968      981      +13     
  Branches      123      125       +2     
==========================================
+ Hits          540      551      +11     
- Misses        428      430       +2     
Files Changed Coverage Δ
.../adapters/paraswap/ParaSwapWithdrawSwapAdapter.sol 84.61% <84.61%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miguelmtzinf miguelmtzinf merged commit b7ead26 into master Aug 22, 2023
1 check passed
@miguelmtzinf miguelmtzinf deleted the feat/withdraw-swap branch August 22, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants