-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: paraswap permit #1399
feat: paraswap permit #1399
Conversation
This pull request has been linked to 1 task:
|
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
Page | Size (compressed) |
---|---|
global |
482.21 KB (🟡 +3.3 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Four Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/faucet |
22.15 KB (🟡 +85 B) |
504.36 KB |
/governance/ipfs-preview |
105.46 KB (-3 B) |
587.67 KB |
/governance/proposal |
105.62 KB (-3 B) |
587.83 KB |
/governance/proposal/[proposalId] |
60.32 KB (-3 B) |
542.53 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
link T-1876 |
@defispartan all actions related to paraswap and usdt on any market failing (for repay as collateral and swap ) |
|
|
Not sure if that's critical, but might be confusing in UI — error message stays on the screen, even when I'm trying to do a new action. Path:
Should we hide old errors since I'm trying to perform a new action? |
|
|
@defispartan Looks great! thanks |
there is a problem with swap action for USDT on ETH and avalanche market, only on fork it's every time failing with
by this reason Ci failing, at same time on mainnet it's work fine |
@defispartan also found one more problem but on mainnet with swaping MATIC to DAI tx failing
|
|
|
|
General Changes
Developer Notes
Signature request is generated in new helper function in
poolSlice
. This should be moved to @aave/contract-helpers, bundled with approval tx building, and re-used for pool permit functions, staking, and migration tool as started hereRefactoring this before the migration PR will cause large conflicts though, so this approach is temporary.
Author Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
main
If the PR is ready for review:
Open
state and not inDraft
modeReady for Dev Review
label has been addedReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.example
file as well as the pertinant.github/actions/*
files